Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-24699

Performance issue due to duplicate forums iterated over in the DiscussionForumTool.getForums()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 2.8.2
    • Fix Version/s: 2.8.3, 2.9.0, 10.0
    • Component/s: Messages Tool
    • Labels:
    • Environment:
      Tomcat 5.5
      Database: Oracle, MySQL
    • Previous Issue Keys:
      MSGCNTR-683

      Description

      In org.sakaiproject.tool.messageforums.DiscussionForumTool.getForums(), a List of DiscussionForum's called 'tempForums' gets populated with duplicates and soon gets iterated over:
      for (DiscussionForum forum: tempForums) {

      This loop has a nested loop that iterates over topics, so for some sites with lots of topics, the tempForums loop takes an excessive amounts of time often causing users to wait several minutes to do most actions within the forums tool. By removing duplicates (in java code), I've cut the loading time for a forum with 500 topics from ~1 minute to ~5 seconds.

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                baholladay Bryan Holladay
                Reporter:
                arwhyte Anthony Whyte
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration