Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-10748

Error changing section size from limited to unlimited

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.0, 2.4.1
    • Fix Version/s: 2.5.0
    • Component/s: Section Info
    • Labels:
      None
    • Previous Issue Keys:

      Description

      1. Create an internally managed section with a specified size limit

      2. Edit the section

      3. Click on the radio button 'Unlimited number of students in section' and click on Update button below.

      The section does not change to unlimited, and this appears in the logs:

      WARN: Attribute 'for' of label component with id editSectionForm:sectionTable:0:_idJsp39 is not defined (2007-07-16 10:36:17,289 TP-Processor1_org.apache.myfaces.renderkit.html.HtmlLabelRenderer)

      WARN: There should always be a submitted value for an input if it is rendered, its form is submitted, and it is not disabled or read-only. Component :

      {Component-Path : [Class: javax.faces.component.UIViewRoot,ViewId: /editSection.jsp][Class: javax.faces.component.html.HtmlForm,Id: editSectionForm][Class: org.apache.myfaces.custom.aliasbean.AliasBean,Id: _idJsp22][Class: org.apache.myfaces.component.html.ext.HtmlDataTable,Id: sectionTable][Class: javax.faces.component.UIColumn,Id: _idJsp24][Class: javax.faces.component.html.HtmlPanelGrid,Id: _idJsp25][Class: javax.faces.component.html.HtmlPanelGroup,Id: _idJsp30][Class: org.apache.myfaces.custom.div.Div,Id: _idJsp35][Class: javax.faces.component.html.HtmlInputText,Id: maxEnrollmentInput]}

      (2007-07-16 10:36:19,643 TP-Processor7_org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils)

      The only way around this is to:

      • delete the value in the input box next to ' Limit number of students in section to'
      • click Update
      • you get a warning, viz. 'There were problems with the last action. Please see details below.'
      • click on Unlimited radio button
      • Click Update

      then the section updates correctly to unlimited.

        Gliffy Diagrams

          Activity

          Stephen Marquard created issue -
          Peter A. Knoop made changes -
          Field Original Value New Value
          Assignee Peter A. Knoop [ knoop ] Josh Holtzman [ jholtzman ]
          Hide
          Josh Holtzman added a comment -

          Fixed – if you can call it that – as of r32610. It turns out that recent versions of myfaces throw away the entire form submission if the UI toggles a text input to be disabled (hence, the component's value is not sent back in the form post) via javascript. The workaround is to re-enable the text input(s) just before submission. This is stupid, but I couldn't think of another way to handle this behavior.

          Show
          Josh Holtzman added a comment - Fixed – if you can call it that – as of r32610. It turns out that recent versions of myfaces throw away the entire form submission if the UI toggles a text input to be disabled (hence, the component's value is not sent back in the form post) via javascript. The workaround is to re-enable the text input(s) just before submission. This is stupid, but I couldn't think of another way to handle this behavior.
          Josh Holtzman made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s Nightly/SVN-Trunk [ 10090 ]
          Resolution Fixed [ 1 ]
          Assignee Josh Holtzman [ jholtzman ] Stephen Marquard [ smarquard ]
          Josh Holtzman 16/Jul/2007 3:36 PM CDT
          View full commit
          SAK-10748 -- Stephen recently asked whether JSF is evil. Well, in some respects it is indeed. Here's my latest JSF annoyance: myfaces throws away the entire form submission if the UI toggles a text input to be disabled (hence, the component's value is not sent back in the form post). The workaround is to re-enable the text input(s) just before submission. This is stupid, but I couldn't think of another way to handle this behavior. Ugh.

          git-svn-id: https://source.sakaiproject.org/svn/sections/trunk@32610 66ffb92e-73f9-0310-93c1-f5514f145a0a
          Repository Revision Date User Message
          Sakai Trunk Repository #32610 Mon Jul 16 15:36:35 CDT 2007 jholtzman@berkeley.edu SAK-10748 -- Stephen recently asked whether JSF is evil. Well, in some respects it is indeed. Here's my latest JSF annoyance: myfaces throws away the entire form submission if the UI toggles a text input to be disabled (hence, the component's value is not sent back in the form post). The workaround is to re-enable the text input(s) just before submission. This is stupid, but I couldn't think of another way to handle this behavior. Ugh.
          Files Changed
          MODIFY /sections/trunk/sections-app/src/webapp/common/js/sections.js
          MODIFY /sections/trunk/sections-app/src/webapp/common/editSection.jsp
          MODIFY /sections/trunk/sections-app/src/java/org/sakaiproject/tool/section/jsf/backingbean/EditSectionBean.java
          Repository Revision Date User Message
          Sakai Trunk Repository #32623 Mon Jul 16 16:58:24 CDT 2007 jholtzman@berkeley.edu SAK-10748 -- Removed an unnecessary log.info statement
          Files Changed
          MODIFY /sections/trunk/sections-app/src/java/org/sakaiproject/tool/section/jsf/backingbean/EditSectionBean.java
          Peter A. Knoop made changes -
          Workflow jira [ 23301 ] Sakai [ 31287 ]
          Peter A. Knoop made changes -
          Workflow Sakai [ 31287 ] jira [ 42804 ]
          Peter A. Knoop made changes -
          Fix Version/s 2.5.0.001 [ 10940 ]
          Fix Version/s Nightly/SVN-Trunk [ 10090 ]
          Hide
          JS added a comment -

          Verified on Sakai QA Network qa2-us (svn tags/sakai_2-5-0_QA_002) using Oracle - Built: 09/27/07 16:36 - Sakai Revision: 35908 - Server rambutan

          Show
          JS added a comment - Verified on Sakai QA Network qa2-us (svn tags/sakai_2-5-0_QA_002) using Oracle - Built: 09/27/07 16:36 - Sakai Revision: 35908 - Server rambutan
          JS made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Peter A. Knoop made changes -
          Affects Version/s 2.4.1 [ 10915 ]
          Filter Maintainer made changes -
          2.5.x Status None
          Filter Maintainer made changes -
          2.4.x Status None
          Filter Maintainer made changes -
          2.6.x Status None
          Aaron Zeckoski made changes -
          Workflow jira [ 42804 ] Sakai CLE workflow [ 100324 ]

            People

            • Assignee:
              Stephen Marquard
              Reporter:
              Stephen Marquard
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Git Source Code