Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-1162

JSF tag sakaix:pager producing non-Style-Guide-compliant HTML

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.0.1, 2.1.0, 2.1.1, 2.1.2, 2.2.0, 2.2.1, 2.2.2, 2.2.3
    • Fix Version/s: 2.2.x, 2.3.0
    • Component/s: JSF
    • Labels:
      None

      Description

      The "sakaix:pager" tag is still generating a <span class="instruction"> and <br/> tag for the navigation context line.

      <sakaix:pager id="pager" totalItems="#

      {bean.dataRows}

      " firstItem="#

      {bean.firstRow}

      " pageSize="#

      {bean.maxDisplayedRows}

      " textStatus="#

      {msgs.paging_status_students}

      " />

      Turns into:

      <span class="nav"><span class="instruction">Viewing 1 to 0 of 0 students</span><br />
      <input type="submit" name="gbForm:pager_first" value="|<" disabled="disabled"/>
      <input type="submit" name="gbForm:pager_prev" value="<" disabled="disabled"/>
      <select name="gbForm:pager_pageSize" id="gbForm:pager_pageSize" onchange="javascript:this.form.submit(); return false;">
      <option value="5">Show 5</option>
      <option value="10">Show 10</option>
      <option selected="selected" value="20">Show 20</option>
      <option value="50">Show 50</option>
      <option value="100">Show 100</option>
      <option value="0">Show all</option>
      </select>
      <input type="submit" name="gbForm:pager_next" value=">" disabled="disabled"/>
      <input type="submit" name="gbForm:pager_last" value=">|" disabled="disabled"/>
      <input type="hidden" name="gbForm:pager_pastItem" value="0"/></span>

      This makes it impossible to control the formatting of the informational (not instructional) message or to control the vertical space between the mesage and the select dropdown. As you can see from the attached screenshot, the spacing currently looks wildly off. (Compare Ben Brophy's graphic for the Gradebook specification, in CVS at "sakai2/gradebook/xdocs/specs/2.gif".)

      In "scratch/styleguide/example/list-action.html", the relevant section looks like:

      <div class="listNav">Viewing 1 - 10 of XXX items<br>
      <input name="Submit" value="|<" type="submit">
      <input name="Submit" value="<" type="submit">
      <select name="select2"><option selected="selected">Show 10</option></select>
      <input name="Submit" value=">" type="submit">
      <input name="Submit" value=">|" type="submit">
      </div>

      This doesn't give the customer as much control as putting the context message in its own <div class="listViewing"> tag would, but it's still better than what's currently being produced.

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                raydavis Ray Davis (Inactive)
                Reporter:
                raydavis Ray Davis (Inactive)
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration