Sakai
  1. Sakai
  2. SAK-12844

WebDAV exposes Dropbox student folders as eid rather than displayid

    Details

    • Type: Bug Bug
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.4.0, 2.4.1, 2.5.0, 2.5.2, 2.5.3
    • Fix Version/s: None
    • Component/s: Drop box, WebDAV
    • Labels:
      None
    • Previous Issue Keys:

      Description

      As per the linked (closed) bug, dropboxes are being exposed by eid through webdav. Since this is user-facing, it would be more logical to expose display ids. This is a problem for institutions that have implemented display ids that are distinct from their eids, like UC Davis.

        Issue Links

          Activity

          James Renfro made changes -
          Field Original Value New Value
          Link This issue relates to SAK-5443 [ SAK-5443 ]
          James Renfro made changes -
          Summary WebDAV exposes dropboxes as eid rather than displayid WebDAV exposes Dropbox student folders as eid rather than displayid
          James Renfro made changes -
          Description As per the linked (closed) bug, dropboxes are being exposed by eid through webdav. However, since this is user-facing, it would be more logical to expose displayids. This is a problem for institutions that have implemented display ids that are distinct from their eids, like UC Davis. As per the linked (closed) bug, dropboxes are being exposed by eid through webdav. Since this is user-facing, it would be more logical to expose display ids. This is a problem for institutions that have implemented display ids that are distinct from their eids, like UC Davis.
          Hide
          Peter A. Knoop added a comment -
          James, are your display ids unique? What happens if you have two students named John Smith in a course?
          Show
          Peter A. Knoop added a comment - James, are your display ids unique? What happens if you have two students named John Smith in a course?
          Hide
          James Renfro added a comment - - edited
          I think you may be confusing display ids with display names. Sakai has both -- a display name is John Smith, a display id is some recognizable id for that individual -- recognizable to the instructor, as distinct from an institution's eid, which may be opaque. So for example, in our system John Smith's eid might be 01234556, and his displayid might be jlsmith.

          The default behavior, for institutions that do not implement display id, is to drop through, so eids will be exposed instead -- so for everybody else, the behavior will stay the same. For us, and any institutions that use display ids, the correct id will be shown.
          Show
          James Renfro added a comment - - edited I think you may be confusing display ids with display names. Sakai has both -- a display name is John Smith, a display id is some recognizable id for that individual -- recognizable to the instructor, as distinct from an institution's eid, which may be opaque. So for example, in our system John Smith's eid might be 01234556, and his displayid might be jlsmith. The default behavior, for institutions that do not implement display id, is to drop through, so eids will be exposed instead -- so for everybody else, the behavior will stay the same. For us, and any institutions that use display ids, the correct id will be shown.
          Hide
          Peter A. Knoop added a comment -
          You're right, I am.
          Show
          Peter A. Knoop added a comment - You're right, I am.
          Peter A. Knoop made changes -
          Assignee Peter A. Knoop [ knoop ] John Leasia [ jleasia ]
          Hide
          John Leasia added a comment -
          Jim, if this is a webdav issue and not resources, please assign back to Peter as I'm not sure who is handling webdav jiras.
          Show
          John Leasia added a comment - Jim, if this is a webdav issue and not resources, please assign back to Peter as I'm not sure who is handling webdav jiras.
          John Leasia made changes -
          Assignee John Leasia [ jleasia ] Jim Eng [ jimeng ]
          Hide
          Cheryl Johns added a comment -
          As an aside to this, is there a way to display the person's name, not their ID (login ID) when using Webdav? Our users log in with a NetID (a combination of letters and numbers based on their initials), which makes it difficult for an instructor to know which student owns which dropbox since their full name is not shown. Is this even possible?
          Show
          Cheryl Johns added a comment - As an aside to this, is there a way to display the person's name, not their ID (login ID) when using Webdav? Our users log in with a NetID (a combination of letters and numbers based on their initials), which makes it difficult for an instructor to know which student owns which dropbox since their full name is not shown. Is this even possible?
          Hide
          James Renfro added a comment -
          In theory the logic would be the same as what I'm suggesting -- only you might want to take into account Peter's comment since display names are not necessarily unique. So maybe something like:

          "First Last (displayid)"
          Show
          James Renfro added a comment - In theory the logic would be the same as what I'm suggesting -- only you might want to take into account Peter's comment since display names are not necessarily unique. So maybe something like: "First Last (displayid)"
          James Renfro made changes -
          Assignee Jim Eng [ jimeng ] James Renfro [ jrenfro@ucdavis.edu ]
          Hide
          James Renfro added a comment -
          I'm going to take a stab at fixing this and contributing a patch. I can see what Nuno did in SAK-5443 and that provides a good model for this fix.
          Show
          James Renfro added a comment - I'm going to take a stab at fixing this and contributing a patch. I can see what Nuno did in SAK-5443 and that provides a good model for this fix.
          Hide
          James Renfro added a comment - - edited
          Although this isn't a perfect solution for us -- given the constraints of the current DavServlet, the best I'm able to do in the way of a fix is to modify the code to display "display name (eid)" rather than just "eid". So just to be clear, if we're dealing with a student named John Doe with a display id of "jdoe" and an eid of "123", this will result in a drop box labeled:

          John Doe (123)

          The student will still be able to dav in using either
          (1) /dav/group-user/simple-course/jdoe
          or
          (2) /dav/group-user/simple-course/123

          as per Nuno's original patch.

          I'm attaching a patch to accomplish this versus the 2.5.x branch, which should be helpful for anyone who uses opaque eids and wants their maintain/instructor users to be able to recognize the member dropboxes.

          One thing that QA will have to establish is that the spaces and parentheses aren't going to cause problems for certain dav clients.
          Show
          James Renfro added a comment - - edited Although this isn't a perfect solution for us -- given the constraints of the current DavServlet, the best I'm able to do in the way of a fix is to modify the code to display "display name (eid)" rather than just "eid". So just to be clear, if we're dealing with a student named John Doe with a display id of "jdoe" and an eid of "123", this will result in a drop box labeled: John Doe (123) The student will still be able to dav in using either (1) /dav/group-user/simple-course/jdoe or (2) /dav/group-user/simple-course/123 as per Nuno's original patch. I'm attaching a patch to accomplish this versus the 2.5.x branch, which should be helpful for anyone who uses opaque eids and wants their maintain/instructor users to be able to recognize the member dropboxes. One thing that QA will have to establish is that the spaces and parentheses aren't going to cause problems for certain dav clients.
          James Renfro made changes -
          Attachment SAK-12844.patch [ 15446 ]
          James Renfro made changes -
          Assignee James Renfro [ jrenfro@ucdavis.edu ] Peter A. Knoop [ knoop ]
          James Renfro made changes -
          Assignee Peter A. Knoop [ knoop ] James Renfro [ jrenfro@ucdavis.edu ]
          James Renfro made changes -
          Attachment SAK-12844.patch [ 15446 ]
          James Renfro made changes -
          Comment [ Peter - can you please assign this to the webdav maintainer for evaluation/committing? Thanks. ]
          Hide
          James Renfro added a comment -
          Okay, on further analysis, that patch doesn't look good, I've removed. Will re-add when I get a chance to ensure that it's really working correctly.
          Show
          James Renfro added a comment - Okay, on further analysis, that patch doesn't look good, I've removed. Will re-add when I get a chance to ensure that it's really working correctly.
          Filter Maintainer made changes -
          2.5.x Status None
          Filter Maintainer made changes -
          2.4.x Status None
          Filter Maintainer made changes -
          Affects Version/s 2.5.1 [ 11101 ]
          Filter Maintainer made changes -
          Affects Version/s 2.5.3 [ 11115 ]
          Affects Version/s 2.4.0 [ 10694 ]
          Filter Maintainer made changes -
          2.6.x Status None
          Hide
          Adam Marshall added a comment -
          James - did you ever improve your patch? we would be interested if you did!
          Show
          Adam Marshall added a comment - James - did you ever improve your patch? we would be interested if you did!
          Hide
          James Renfro added a comment -
          I'm afraid I ran into the wall on this one, and never found a satisfactory solution.
          Show
          James Renfro added a comment - I'm afraid I ran into the wall on this one, and never found a satisfactory solution.
          Aaron Zeckoski made changes -
          Workflow jira [ 45775 ] Sakai CLE workflow [ 86969 ]

            People

            • Assignee:
              James Renfro
              Reporter:
              James Renfro
            • Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated: