Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.4.0, 2.4.1, 2.5.0, 2.5.2, 2.5.3
-
Fix Version/s: 2.6.x
-
Component/s: Attachment Widget, Content, Content service (Pre-K1/2.6), Internationalization
-
Labels:None
Description
Issue Links
- incorporates
-
SAK-11076
Cannot view attachment with foreign character file name
-
-
SAK-12299
attachments cannot be downloaded when file names has accents
-
-
SAK-12300
attachments cannot be downloaded when file names has accents
-
- is related to
-
SAK-17459
Fix content URL double-encoding issues and check correct encoding
-
- relates to
-
KNL-213
BaseResourceEdit return non url-encoded urls
-
Activity
Hide
Peter A. Knoop
added a comment -
Permalink
Jim, there seem to be multiple tools that are experiencing problems with attachements that have international characters in their names. Could you take a look at this and determine if it is something you can take care of in the content attachment widget, or if it is just a conincidence and there are multiple bugs in the individual tools? Thanks.
Show
Peter A. Knoop
added a comment - Jim, there seem to be multiple tools that are experiencing problems with attachements that have international characters in their names. Could you take a look at this and determine if it is something you can take care of in the content attachment widget, or if it is just a conincidence and there are multiple bugs in the individual tools? Thanks.
| Assignee | Peter A. Knoop [ knoop ] | Jim Eng [ jimeng ] |
we solved this by expanding adding a call to Validator.escapeUrl() in BaseResourceEdit.getUrl() and expanding the one in BaseContentService.getUrl() (see attached patch)
works for message-center and samigo
works for message-center and samigo
Show
Klas Lindfors
added a comment - we solved this by expanding adding a call to Validator.escapeUrl() in BaseResourceEdit.getUrl() and expanding the one in BaseContentService.getUrl() (see attached patch)
works for message-center and samigo
| Attachment | content-encode.patch [ 15750 ] |
| 2.5.x Status | None |
| 2.4.x Status | None |
| Affects Version/s | 2.5.1 [ 11101 ] |
Klas,
You have mentioned this is fixed for samigo. However, I just tested this in nightly2, the error reported inSAK-12300 is still there... Do I need to fix something in Samigo? Thanks.
You have mentioned this is fixed for samigo. However, I just tested this in nightly2, the error reported in
Show
Karen Tsao
added a comment - Klas,
You have mentioned this is fixed for samigo. However, I just tested this in nightly2, the error reported in SAK-12300 is still there... Do I need to fix something in Samigo? Thanks.
The patch I attached to this jira is against content-impl, it's still not applied to trunk from what I can see. We've been running with this patch in production for 4 months, working perfectly.
This can be fixed by making sure urls from content-api is passed through url escaping, but would probably be better if fixed in content-imp.
This can be fixed by making sure urls from content-api is passed through url escaping, but would probably be better if fixed in content-imp.
Show
Klas Lindfors
added a comment - The patch I attached to this jira is against content-impl, it's still not applied to trunk from what I can see. We've been running with this patch in production for 4 months, working perfectly.
This can be fixed by making sure urls from content-api is passed through url escaping, but would probably be better if fixed in content-imp.
Jim, any further word on this issue yet? Is it something we can get addressed for 2.6? Thanks.
Show
Peter A. Knoop
added a comment - Jim, any further word on this issue yet? Is it something we can get addressed for 2.6? Thanks.
| Assignee | Jim Eng [ jimeng ] | Peter A. Knoop [ knoop ] |
Beth, is this one you could look at, or should it go to Ian? Thanks.
Show
Peter A. Knoop
added a comment - Beth, is this one you could look at, or should it go to Ian? Thanks.
| Assignee | Peter A. Knoop [ knoop ] | Beth Kirschner [ bkirschn ] |
| Affects Version/s | 2.5.3 [ 11115 ] |
| 2.6.x Status | None |
I've verified that these problems have been fixed in the 2.6.x release -- sorry I can't track down the exact revision, but there has been a fair amount of internationalization fixes for this release. Feel free to re-open if you continue to see problems with the 2.6 release. I've _not_ applied the patch since this appears to have been fixed elsewhere (but thanks!).
Show
Beth Kirschner
added a comment - I've verified that these problems have been fixed in the 2.6.x release -- sorry I can't track down the exact revision, but there has been a fair amount of internationalization fixes for this release. Feel free to re-open if you continue to see problems with the 2.6 release. I've _not_ applied the patch since this appears to have been fixed elsewhere (but thanks!).
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Fix Version/s | 2.6.x [ 11278 ] | |
| Resolution | Fixed [ 1 ] |
Also apply this patch if you want directory URLs to be correctly escaped.
Show
Matthew Buckett
added a comment - Also apply this patch if you want directory URLs to be correctly escaped.
| Attachment | SAK-13532.patch [ 17696 ] |
We currently have this fixed in our local build but wouldn't it make sense to patch 2.5.x as well?
Show
Matthew Buckett
added a comment - We currently have this fixed in our local build but wouldn't it make sense to patch 2.5.x as well?
| Attachment |
|
| Attachment | SAK-13532.patch [ 17697 ] |
Which patches should be used for 2.5.x?
Show
Jean-François Lévêque
added a comment - Which patches should be used for 2.5.x?
We have both content-encode.patch and SAK-13532.patch in our 2.5.x build.
They are both attached to this ticket.
They are both attached to this ticket.
Show
Matthew Buckett
added a comment - We have both content-encode.patch and SAK-13532 .patch in our 2.5.x build.
They are both attached to this ticket.
Could someone else than Matthew and Klas confirm both patches are ok with 2.5.x by closing this issue?
or
Could Matthew and Klas confirm each other's patch is ok with 2.5.x and close this issue?
or
Could Matthew and Klas confirm each other's patch is ok with 2.5.x and close this issue?
Show
Jean-François Lévêque
added a comment - Could someone else than Matthew and Klas confirm both patches are ok with 2.5.x by closing this issue?
or
Could Matthew and Klas confirm each other's patch is ok with 2.5.x and close this issue?
IMO this isn't fixed for 2.6. Atleast getUrl() on BaseResourceEdit still returns an url that isn't encoded.
I have reported this asKNL-213. For us it breaks with files uploaded in syllabus and test&quizzes.
I have reported this as
Show
Klas Lindfors
added a comment - IMO this isn't fixed for 2.6. Atleast getUrl() on BaseResourceEdit still returns an url that isn't encoded.
I have reported this as KNL-213 . For us it breaks with files uploaded in syllabus and test&quizzes.
Klas, can you open a new JIRA that describes the specific use case in Syllabus and Test & Quizzes that causes trouble? I can try to track down the problems in BaseResourceEdit, but am not that familiar with the Syllabus & T&Q tools. I'd also link them to KNL-213. Thanks!
Show
Beth Kirschner
added a comment - Klas, can you open a new JIRA that describes the specific use case in Syllabus and Test & Quizzes that causes trouble? I can try to track down the problems in BaseResourceEdit, but am not that familiar with the Syllabus & T&Q tools. I'd also link them to KNL-213 . Thanks!
I had this on the 2.5.6 merge candidate list (even started testing it locally) but the work done at KNL-213 shows that it's more involved. As such, I am recommending against a 2.5.x merge.
Show
Seth Theriault
added a comment - I had this on the 2.5.6 merge candidate list (even started testing it locally) but the work done at KNL-213 shows that it's more involved. As such, I am recommending against a 2.5.x merge.
Hi, I'm Miriam Esteve from SAMOO. Adding this patch also fixes this bug (SAK-11076) in syllabus. But there is a problem, adding this patch fixes samigo and syllabus but Melete stops working properly.
Not a big problem, melete still works, but the title of the file, if you have special characters appears ESCAPED. For example, the text file called: "Texto en Español.txt" in all places where it appears the title of the file looks like this:
Text% 20of% 20Espa% C3% B1ol.txt
To fix this error, I added a decoder in several get of the class: URLDecoder.decode (XXXXX, "UTF-8"); to decode so, what in the previous patch had been codified.
Adding this patch to this bug.
Not a big problem, melete still works, but the title of the file, if you have special characters appears ESCAPED. For example, the text file called: "Texto en Español.txt" in all places where it appears the title of the file looks like this:
Text% 20of% 20Espa% C3% B1ol.txt
To fix this error, I added a decoder in several get of the class: URLDecoder.decode (XXXXX, "UTF-8"); to decode so, what in the previous patch had been codified.
Adding this patch to this bug.
Show
Miriam Esteve Velazquez
added a comment - Hi, I'm Miriam Esteve from SAMOO. Adding this patch also fixes this bug ( SAK-11076 ) in syllabus. But there is a problem, adding this patch fixes samigo and syllabus but Melete stops working properly.
Not a big problem, melete still works, but the title of the file, if you have special characters appears ESCAPED. For example, the text file called: "Texto en Español.txt" in all places where it appears the title of the file looks like this:
Text% 20of% 20Espa% C3% B1ol.txt
To fix this error, I added a decoder in several get of the class: URLDecoder.decode (XXXXX, "UTF-8"); to decode so, what in the previous patch had been codified.
Adding this patch to this bug.
| Attachment | melete_specialChar_utl.patch [ 19694 ] |
| Attachment | melete_specialChar_utl.patch [ 19694 ] |
Patch to decode in Melete, that in the previous patch had been codified.
Show
Miriam Esteve Velazquez
added a comment - - edited Patch to decode in Melete, that in the previous patch had been codified.
| Attachment | melete_specialChar_utf.patch [ 19695 ] |
| Comment | [ Patch to decode in Melete, what in the previous patch had been codified. ] |
Did you put the melete patch on etudes.org's JIRA, Miriam Esteve?
Show
Jean-François Lévêque
added a comment - Did you put the melete patch on etudes.org's JIRA, Miriam Esteve?
| Workflow | jira [ 47011 ] | Sakai CLE workflow [ 89530 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |