Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-13532

International characters in attachment names causing problems

    Details

      Description

      There are several issues which appear to be related, where attachments cannot be accessed that have international characters in their names:

      SAK-11076
      SAK-12299
      SAK-12300

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              knoop Peter A. Knoop created issue -
              knoop Peter A. Knoop made changes -
              Field Original Value New Value
              Link This issue incorporates SAK-11076 [ SAK-11076 ]
              knoop Peter A. Knoop made changes -
              Link This issue incorporates SAK-12299 [ SAK-12299 ]
              knoop Peter A. Knoop made changes -
              Link This issue incorporates SAK-12300 [ SAK-12300 ]
              Hide
              knoop Peter A. Knoop added a comment -

              Jim, there seem to be multiple tools that are experiencing problems with attachements that have international characters in their names. Could you take a look at this and determine if it is something you can take care of in the content attachment widget, or if it is just a conincidence and there are multiple bugs in the individual tools? Thanks.

              Show
              knoop Peter A. Knoop added a comment - Jim, there seem to be multiple tools that are experiencing problems with attachements that have international characters in their names. Could you take a look at this and determine if it is something you can take care of in the content attachment widget, or if it is just a conincidence and there are multiple bugs in the individual tools? Thanks.
              knoop Peter A. Knoop made changes -
              Assignee Peter A. Knoop [ knoop ] Jim Eng [ jimeng ]
              Hide
              kllin Klas Lindfors added a comment -

              we solved this by expanding adding a call to Validator.escapeUrl() in BaseResourceEdit.getUrl() and expanding the one in BaseContentService.getUrl() (see attached patch)

              works for message-center and samigo

              Show
              kllin Klas Lindfors added a comment - we solved this by expanding adding a call to Validator.escapeUrl() in BaseResourceEdit.getUrl() and expanding the one in BaseContentService.getUrl() (see attached patch) works for message-center and samigo
              kllin Klas Lindfors made changes -
              Attachment content-encode.patch [ 15750 ]
              filters Filter Maintainer made changes -
              2.5.x Status None
              filters Filter Maintainer made changes -
              2.4.x Status None
              filters Filter Maintainer made changes -
              Affects Version/s 2.5.1 [ 11101 ]
              Hide
              ktsao Karen Tsao added a comment -

              Klas,

              You have mentioned this is fixed for samigo. However, I just tested this in nightly2, the error reported in SAK-12300 is still there... Do I need to fix something in Samigo? Thanks.

              Show
              ktsao Karen Tsao added a comment - Klas, You have mentioned this is fixed for samigo. However, I just tested this in nightly2, the error reported in SAK-12300 is still there... Do I need to fix something in Samigo? Thanks.
              Hide
              kllin Klas Lindfors added a comment -

              The patch I attached to this jira is against content-impl, it's still not applied to trunk from what I can see. We've been running with this patch in production for 4 months, working perfectly.
              This can be fixed by making sure urls from content-api is passed through url escaping, but would probably be better if fixed in content-imp.

              Show
              kllin Klas Lindfors added a comment - The patch I attached to this jira is against content-impl, it's still not applied to trunk from what I can see. We've been running with this patch in production for 4 months, working perfectly. This can be fixed by making sure urls from content-api is passed through url escaping, but would probably be better if fixed in content-imp.
              Hide
              knoop Peter A. Knoop added a comment -

              Jim, any further word on this issue yet? Is it something we can get addressed for 2.6? Thanks.

              Show
              knoop Peter A. Knoop added a comment - Jim, any further word on this issue yet? Is it something we can get addressed for 2.6? Thanks.
              Hide
              jimeng Jim Eng added a comment -

              This needs to be handled by someone with kernel commit.

              Show
              jimeng Jim Eng added a comment - This needs to be handled by someone with kernel commit.
              jimeng Jim Eng made changes -
              Assignee Jim Eng [ jimeng ] Peter A. Knoop [ knoop ]
              Hide
              knoop Peter A. Knoop added a comment -

              Beth, is this one you could look at, or should it go to Ian? Thanks.

              Show
              knoop Peter A. Knoop added a comment - Beth, is this one you could look at, or should it go to Ian? Thanks.
              knoop Peter A. Knoop made changes -
              Assignee Peter A. Knoop [ knoop ] Beth Kirschner [ bkirschn ]
              bkirschn Beth Kirschner made changes -
              Link This issue duplicates SAK-12300 [ SAK-12300 ]
              bkirschn Beth Kirschner made changes -
              Link This issue duplicates SAK-12300 [ SAK-12300 ]
              filters Filter Maintainer made changes -
              Affects Version/s 2.5.3 [ 11115 ]
              filters Filter Maintainer made changes -
              2.6.x Status None
              Hide
              bkirschn Beth Kirschner added a comment -

              I've verified that these problems have been fixed in the 2.6.x release – sorry I can't track down the exact revision, but there has been a fair amount of internationalization fixes for this release. Feel free to re-open if you continue to see problems with the 2.6 release. I've not applied the patch since this appears to have been fixed elsewhere (but thanks!).

              Show
              bkirschn Beth Kirschner added a comment - I've verified that these problems have been fixed in the 2.6.x release – sorry I can't track down the exact revision, but there has been a fair amount of internationalization fixes for this release. Feel free to re-open if you continue to see problems with the 2.6 release. I've not applied the patch since this appears to have been fixed elsewhere (but thanks!).
              bkirschn Beth Kirschner made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 2.6.x [ 11278 ]
              Resolution Fixed [ 1 ]
              Hide
              buckett Matthew Buckett added a comment -

              Also apply this patch if you want directory URLs to be correctly escaped.

              Show
              buckett Matthew Buckett added a comment - Also apply this patch if you want directory URLs to be correctly escaped.
              buckett Matthew Buckett made changes -
              Attachment SAK-13532.patch [ 17696 ]
              Hide
              buckett Matthew Buckett added a comment -

              We currently have this fixed in our local build but wouldn't it make sense to patch 2.5.x as well?

              Show
              buckett Matthew Buckett added a comment - We currently have this fixed in our local build but wouldn't it make sense to patch 2.5.x as well?
              buckett Matthew Buckett made changes -
              Attachment SAK-13532.patch [ 17696 ]
              buckett Matthew Buckett made changes -
              Attachment SAK-13532.patch [ 17697 ]
              Hide
              jean-francois.leveque@upmc.fr Jean-François Lévêque added a comment -

              Which patches should be used for 2.5.x?

              Show
              jean-francois.leveque@upmc.fr Jean-François Lévêque added a comment - Which patches should be used for 2.5.x?
              Hide
              buckett Matthew Buckett added a comment -

              We have both content-encode.patch and SAK-13532.patch in our 2.5.x build.
              They are both attached to this ticket.

              Show
              buckett Matthew Buckett added a comment - We have both content-encode.patch and SAK-13532 .patch in our 2.5.x build. They are both attached to this ticket.
              Hide
              jean-francois.leveque@upmc.fr Jean-François Lévêque added a comment -

              Could someone else than Matthew and Klas confirm both patches are ok with 2.5.x by closing this issue?
              or
              Could Matthew and Klas confirm each other's patch is ok with 2.5.x and close this issue?

              Show
              jean-francois.leveque@upmc.fr Jean-François Lévêque added a comment - Could someone else than Matthew and Klas confirm both patches are ok with 2.5.x by closing this issue? or Could Matthew and Klas confirm each other's patch is ok with 2.5.x and close this issue?
              Hide
              kllin Klas Lindfors added a comment -

              IMO this isn't fixed for 2.6. Atleast getUrl() on BaseResourceEdit still returns an url that isn't encoded.
              I have reported this as KNL-213. For us it breaks with files uploaded in syllabus and test&quizzes.

              Show
              kllin Klas Lindfors added a comment - IMO this isn't fixed for 2.6. Atleast getUrl() on BaseResourceEdit still returns an url that isn't encoded. I have reported this as KNL-213 . For us it breaks with files uploaded in syllabus and test&quizzes.
              Hide
              bkirschn Beth Kirschner added a comment -

              Klas, can you open a new JIRA that describes the specific use case in Syllabus and Test & Quizzes that causes trouble? I can try to track down the problems in BaseResourceEdit, but am not that familiar with the Syllabus & T&Q tools. I'd also link them to KNL-213. Thanks!

              Show
              bkirschn Beth Kirschner added a comment - Klas, can you open a new JIRA that describes the specific use case in Syllabus and Test & Quizzes that causes trouble? I can try to track down the problems in BaseResourceEdit, but am not that familiar with the Syllabus & T&Q tools. I'd also link them to KNL-213 . Thanks!
              buckett Matthew Buckett made changes -
              Link This issue relates to KNL-213 [ KNL-213 ]
              smarquard Stephen Marquard made changes -
              Link This issue is related to SAK-17459 [ SAK-17459 ]
              Hide
              seththeriault Seth Theriault added a comment -

              I had this on the 2.5.6 merge candidate list (even started testing it locally) but the work done at KNL-213 shows that it's more involved. As such, I am recommending against a 2.5.x merge.

              Show
              seththeriault Seth Theriault added a comment - I had this on the 2.5.6 merge candidate list (even started testing it locally) but the work done at KNL-213 shows that it's more involved. As such, I am recommending against a 2.5.x merge.
              Hide
              miesve Miriam Esteve Velazquez added a comment -

              Hi, I'm Miriam Esteve from SAMOO. Adding this patch also fixes this bug (SAK-11076) in syllabus. But there is a problem, adding this patch fixes samigo and syllabus but Melete stops working properly.
              Not a big problem, melete still works, but the title of the file, if you have special characters appears ESCAPED. For example, the text file called: "Texto en Español.txt" in all places where it appears the title of the file looks like this:
              Text% 20of% 20Espa% C3% B1ol.txt

              To fix this error, I added a decoder in several get of the class: URLDecoder.decode (XXXXX, "UTF-8"); to decode so, what in the previous patch had been codified.
              Adding this patch to this bug.

              Show
              miesve Miriam Esteve Velazquez added a comment - Hi, I'm Miriam Esteve from SAMOO. Adding this patch also fixes this bug ( SAK-11076 ) in syllabus. But there is a problem, adding this patch fixes samigo and syllabus but Melete stops working properly. Not a big problem, melete still works, but the title of the file, if you have special characters appears ESCAPED. For example, the text file called: "Texto en Español.txt" in all places where it appears the title of the file looks like this: Text% 20of% 20Espa% C3% B1ol.txt To fix this error, I added a decoder in several get of the class: URLDecoder.decode (XXXXX, "UTF-8"); to decode so, what in the previous patch had been codified. Adding this patch to this bug.
              miesve Miriam Esteve Velazquez made changes -
              Attachment melete_specialChar_utl.patch [ 19694 ]
              miesve Miriam Esteve Velazquez made changes -
              Attachment melete_specialChar_utl.patch [ 19694 ]
              Hide
              miesve Miriam Esteve Velazquez added a comment - - edited

              Patch to decode in Melete, that in the previous patch had been codified.

              Show
              miesve Miriam Esteve Velazquez added a comment - - edited Patch to decode in Melete, that in the previous patch had been codified.
              miesve Miriam Esteve Velazquez made changes -
              Attachment melete_specialChar_utf.patch [ 19695 ]
              miesve Miriam Esteve Velazquez made changes -
              Comment [ Patch to decode in Melete, what in the previous patch had been codified. ]
              Hide
              jean-francois.leveque@upmc.fr Jean-François Lévêque added a comment -

              Did you put the melete patch on etudes.org's JIRA, Miriam Esteve?

              Show
              jean-francois.leveque@upmc.fr Jean-François Lévêque added a comment - Did you put the melete patch on etudes.org's JIRA, Miriam Esteve?
              aaronz Aaron Zeckoski made changes -
              Workflow jira [ 47011 ] Sakai CLE workflow [ 89530 ]
              aaronz Aaron Zeckoski made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              aaronz Aaron Zeckoski made changes -
              Remote Link This issue links to "Page (Confluence)" [ 11832 ]
              aaronz Aaron Zeckoski made changes -
              Remote Link This issue links to "Page (Confluence)" [ 11837 ]

                People

                • Assignee:
                  bkirschn Beth Kirschner
                  Reporter:
                  knoop Peter A. Knoop
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code