Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-14998

downloaded portfolio archive url-encodes the FILENAME and not the URL in the html that refers to it (should be vice-versa)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.3, 2.6.0
    • Fix Version/s: 2.5.6, 2.6.0, 2.7.0
    • Component/s: OSP: Portfolios
    • Labels:
      None
    • Environment:
      server: linux 2.6.24 (ubuntu hardy heron)
      client: windows and linux firefox 2, windows internet explorer

      Description

      downloaded portfolio archive url-encodes the FILENAME and not the URL in the html that refers to it (should be the other way around):

      We're using sakai v2.5.x (revision 54155) at the moment and it exhibits this behavior--

      1. create a portfolio that refers to any resource that contains spaces (or anything requiring URL-encoding) in the file name

      • this could be a templated portfolio or a free-form portfolio

      2. view it on screen to make sure all is well

      3. click the portfolio's "download" link to get the ZIP archive

      4. expand the archive

      5a. examine the HTML that refers to the resource: no URL encoding there!
      5b. check the file name in the "Resources" folder: it's url-encoded!

      As an example, I'm attaching a screen-shot showing downloaded HTML and the Resources file name – in this case I used an image file as the attachment. The HTML contains an <img src="repository/how can black prevail.png" /> tag which should instead be <img src="repository/how%20can%20black%20prevail.png" /> . The file name is "how%20can%20black%20prevail.png" which should instead be "how can black prevail.png". Somehow the "url-encode this string" filter was planted on the filename instead of on the URL.

      Could this be related to http://jira.sakaiproject.org/jira/browse/SAK-13059 ...?

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                bkirschn Beth Kirschner
                Reporter:
                trillich will trillich (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2 hours
                  2h
                  Remaining:
                  Remaining Estimate - 2 hours
                  2h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified

                    Git Source Code