Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-17013

assignment download all problem generates 2 GB of output in catalina.out

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.6.1
    • Component/s: Assignments
    • Labels:
      None

      Description

      Found a thread in a loop generating error messages like this:

      2009-09-22 11:24:59,371 WARN http-443-Processor486 org.sakaiproject.assignment.impl.BaseAssignmentService - org.sakaiproject.assignment.impl.DbAssignmentService@3f35fd95 zipSubmissions --IOException unable to create the zip file for userhwk 2/Hixson, Jeremy(kradakar)_1_2_3_4_5_6_7_8_9_10_11_12_13_14_15_16_17_18_19_20_21_22_23_24_25_26_27_28_29
      30_31_32_33_34_35_36_37_38_39_40_41_42_43_44_45_46_47_48_49_50_51_52_53_54_55_56_57_58_59
      60_61_62_63_64_65_66_67_68_69_70_71_72_73_74_75_76_77_78_79_80_81_82_83_84_85_86_87_88_89_
      90_91_92_93_94_95_96_97_98_99_100_101_102_103_104_105_106_107_108_109_110_111_112_113_114_1
      15_116_117_118_119_120_121_122_123_124_125_126_127_128_129_130_131_132_133_134_135_136_137_
      138_139_140_141_142_143_144_145_146_147_148_149_150_151_152_153_154_155_156_157_158_159_16
      0_161_162_163_164_165_166_167_168_169_170_171_172_173_174_175_176_177_178_179_180_181_182_
      183_184_185_186_187_188_189_190_191_192_193_194_195_196_197_198_199_200_201_202_203_204_20
      5_206_207_208_209_210_211_212_213_214_215_216^C

      Looking at the code for generating zip files, I see a number of problems. If there's an I/O error writing to the ZIP file, it tries again, concatenating a number to the name. First, they probably intended to use _1, _2, etc, not _1, _1_2, _1_2_3, etc. Second the loop has no termination. Third, why are they doing this in the first place? The only obvious way to get an I/O error when writing to the network is if the network connection breaks. In that case trying again won't help.

      I believe the correct fix is to abort on error. But if it isn't, then the name concatenation has to be fixed, and there has to be a limit on retries.

      I consider this a critical error because it can result in a situation where you have to restart the app server.

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                zqian Zhen Qian
                Reporter:
                hedrick Charles Hedrick
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration