Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-17647 Clean up code via static code review sweep for 2.7
  3. SAK-17651

SampleGroupProvider may fail to clean up FileInputStream under Exceptional circumstances

    Details

    • Type: Sub-task
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.6.3, 2.7.0, 2.8.0
    • Component/s: Providers
    • Labels:
      None
    • Environment:
      Static code review

      Description

      On line 437

      protected void update()
      {
      m_usersx = new Properties();

      if (m_xFile != null)
      {
      try

      { m_usersx.load(new FileInputStream(m_xFile)); }

      catch (Exception e)

      { M_log.warn("update: reading users.properties file: " + m_xFile + " : " + e); }

      }
      }

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                dhorwitz David Horwitz
                Reporter:
                a.m.berg@uva.nl Alan Berg
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration