Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-17647 Clean up code via static code review sweep for 2.7
  3. SAK-17659

potential NPE's and s resource leaks in OSP found by static code review

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.7.0, 2.8.0
    • Component/s: OSP: Other
    • Labels:
      None
    • Environment:
      Static code review of 2-7-M2 tag

      Description

      See, we are talking around 40 defects that should be straightforward to clean up. Mostly a question of moving if statements or extra try catch or finally.

      http://builds.sakaiproject.org/code_review/ad-hoc/tags/2.7.0-M2/%20metaobj.txt
      http://builds.sakaiproject.org/code_review/ad-hoc/tags/2.7.0-M2/m2_osp.txt

        Gliffy Diagrams

          Attachments

          1. m2_osp_literals.txt
            69 kB
          2. m2_osp.txt
            18 kB
          3. metaobj.txt
            5 kB
          4. reports.txt
            3 kB

            Issue Links

              Activity

                People

                • Assignee:
                  noahbotimer Noah Botimer
                  Reporter:
                  a.m.berg@uva.nl Alan Berg
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code