Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-18759

Import from archive file does not unroll contents of a zip file correctly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.2, 2.7.0
    • Fix Version/s: 2.6.3, 2.7.1
    • Component/s: Common
    • Labels:
      None
    • CLE Team Issue:
      Yes

      Description

      To Replicate
      -----------------------------
      1) Go to Site Info of existing course as admin user
      2) Import from Archive File
      3) Upload attached ZIP file (Common Cartridge Zip)
      4) Import the "Introduction" and continue through the dialogs
      5) Inspect the Resources

      Result
      -------------------------------
      The directory structure is created correctly in Resources, but the files are not written.

      Reason for Error
      ------------------------------
      Old code would do a check for the size of the next entry in the ZipInputStream:

      int size = (int) entry.getSize();

      It appears that the size may not always be available when unrolling the ZIP. My attached patch works regardless of whether the size is available.

        Gliffy Diagrams

          Zeplin

            Attachments

            1. SAK-18759.patch
              3 kB
            2. SAK-18759-2.6.x.patch
              4 kB
            3. SAK-18759-2.6.x-v2.patch
              4 kB
            4. sample-ims-cc.zip
              1.20 MB

              Issue Links

                Activity

                  People

                  Assignee:
                  dhorwitz David Horwitz
                  Reporter:
                  ottenhoff Sam Ottenhoff
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration