Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-20428

Options form of incorrect type can be saved on a presentation, which cannot be corrected by user

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.7.1, 2.8.0
    • Fix Version/s: 2.7.2, 2.8.1
    • Component/s: OSP: Portfolios
    • Labels:
      None

      Description

      When a user uses multiple tabs or windows within the same session, it is possible to save the wrong type of form as the options form for a presentation. This will typically make the portfolio non-functional due to violating an expectation of the template that the form will be of a given schema. This also cannot be corrected by the user, since there is an implicit options form per presentation, and it cannot be detached.

      Steps to reproduce are:

      1. Create a portfolio against a template with an options form type selected.
      2. Complete the options (Required Settings).
      3. Complete a content form in the portfolio.
      4. Return to the Summary page (TAB 1).
      5. In another window or tab (same browser/session), navigate to the Add/Edit Content page for that portfolio (TAB 2).
      6. Begin editing the options form (TAB 1).
      7. Begin editing the content form (TAB 2).
      8. Click Save on the options form (TAB 1).

      Results:

      The form that should belong to the presentation is saved and attached as the options form. If the form for the item is of a different type than the options form, the portfolio will be unrecoverable. Each time the user attempts to edit the options form, the other form will be edited, and cannot be detached. The user then has to create a new portfolio and reselect all artifacts.

      Solution:

      Check the type of the form attempting to be saved as the options form for a presentation.

      Expected Result after fix:

      An error report should occur and the portfolio should remain functional. If the stack trace is visible, there will be a message about simultaneous editing.

      Notes:

      This isn't a perfect solution in that it doesn't resolve all of the errors that can arise from editing forms in multiple tabs. However, it does avoid the situation where the user cannot continue to work on a given portfolio.

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                noahbotimer Noah Botimer
                Reporter:
                noahbotimer Noah Botimer
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration