Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-21209

setMainFrameHeight in headscripts.js needs to check if the document can be accessed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.3, 2.7.2, 2.8.0
    • Fix Version/s: 2.7.3 [tentative], 2.8.2, 2.9.0
    • Component/s: Reference
    • Labels:
      None
    • CLE Team Issue:
      Yes

      Description

      The method setMainFrameHeight(window.name) needs to have a try/catch block placed around the access of 'document' to catch any possible errors - it doesn't need to do anything with them, just catch them so the rest continues to run.

      If a tool is embedded via a Basic LTI request, and that tool calls setMainFrameHeight then it fails with a security exception:

      Error: Permission denied to access property 'document'
      Source File: http://localhost:8081/library/js/headscripts.js
      Line: 250

      See PRFL-672

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  • Assignee:
                    steve.swinsburg Steve Swinsburg
                    Reporter:
                    steve.swinsburg Steve Swinsburg
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Git Integration