Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-22199

Improve the PDA Portal in its detection of Situations to *not* inline the tool content

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 10.0
    • Component/s: Portal
    • Labels:
      None
    • Property addition/change required:
      Yes

      Description

      Currently, the PDA portal loks at the request URI and applies a regular expression to the URL and if the Regex matches - do not do inlining. There is a property that allows sites to adjust the regex without patching or recompiling:

      portal.pda.bypass=.jpg$|.gif$|...

      You can also do a tool-by tool bypass

      portal.pda.bypass.sakai.web=regex...

      This turns out not to be sufficient. We also need a regex that will allow inline-bypass based on the existance of something in the query string, or even the requested or returned content type. SO this JIRA adds two new properties with suitable defaults:

      portal.pda.bypass.query=wicket:interface
      portal.pda.bypass.type=^application/|^image/|^audio/|^video/|^text/xml|^text/plain

      Both of these can be scoped down to a tool by adding a Sakai tool id to the property name.

      You will know that these need adjustment when you are testing a tool in the PDA portal and start to see broken images, missing CSS, missing Javascript, or failing AJAX requests that are using local URLs that get turned into

      /pda/porta/...

      I will check this code in and leave the JIRA open so folks can do a bit of testing.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  csev Charles Severance
                  Reporter:
                  csev Charles Severance
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration