Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-23407

Skin confusion: hardcoded skins, misuse of properties, confusing portal settings

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 10.0
    • Fix Version/s: None
    • Component/s: Other
    • Labels:

      Description

      In 2.9, the previously straightforward skin.default property became confusing and unintuitive because of the bug in SAK-23395. Investigation as to why things seemed to work so inconsistently SAK-23396 led to the discovery of the fact that nearly every tool was doing something skin-related incorrectly. I've created JIRAs for the most problematic aspects, but not for everything, linked below. The community should consider either revamping the way skinning works, providing clearer documentation on the appropriate ways to use skins, or performing more static analysis on newly introduced core code such as lessonbuilder which wins for most files with hardcoded references to the "default" (but no longer default) skin.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

              is related to

              Bug - A problem which impairs or prevents functionality of the product. SAK-23405 All help content hardcodes "default" skin

              • Major - Major loss of function or need for functionality in production in the near future.
              • Awaiting Review

              Bug - A problem which impairs or prevents functionality of the product. SAK-23394 Chat builds path to skin CSS in an unsafe way

              • Major - Major loss of function or need for functionality in production in the near future.
              • RESOLVED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23397 BaseMessageService builds path to skin CSS in an unsafe way

              • Major - Major loss of function or need for functionality in production in the near future.
              • RESOLVED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23398 Rwiki builds path to skin CSS in an unsafe way

              • Major - Major loss of function or need for functionality in production in the near future.
              • RESOLVED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23399 Metaobj builds path to skin CSS in an unsafe way

              • Major - Major loss of function or need for functionality in production in the near future.
              • RESOLVED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23400 Login builds path to skin CSS in an unsafe way

              • Major - Major loss of function or need for functionality in production in the near future.
              • RESOLVED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23445 Hard coded reference to defautl template in CSS

              • Major - Major loss of function or need for functionality in production in the near future.
              • RESOLVED

              Bug - A problem which impairs or prevents functionality of the product. SAK-37879 Lesson Builder hardcodes the "default" skin in several places

              • Major - Major loss of function or need for functionality in production in the near future.
              • RESOLVED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23395 Need to be able to unset portal.neoprefix

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23396 skin.default no longer works as expected

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23402 Gradebook hardcodes "default" skin in several RSF templates

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23403 Site-Manage hardcodes "default" skin in several RSF templates

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23404 reset-pass hardcodes "default" skin in several RSF templates

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-23994 BasicLTI sends hardcoded reference to /library/skin/default/tool.css in all launch parameters

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-24324 Mailsender hardcodes "default" skin in several RSF templates

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-26451 Polls hardcodes "default" skin in several locations

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-26753 Profile2 builds path to skin CSS in an unsafe way

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-28642 Sitestats builds path to skin CSS in an unsafe way

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-36099 Hardcoded skin in samigo standalone servlet

              • Minor - Minor loss of function, problem where easy workaround is present, or functionality which would be nice to have.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SCO-93 Build link to Sakai tool.css correctly

              • Minor - Minor loss of function, problem where easy workaround is present, or functionality which would be nice to have.
              • CLOSED
              relates to

              Bug - A problem which impairs or prevents functionality of the product. SAK-23824 Create utility class usable across Sakai that captures the rules for skin naming

              • Major - Major loss of function or need for functionality in production in the near future.
              • Verified

                Activity

                  People

                  Assignee:
                  daveadams David Adams
                  Reporter:
                  daveadams David Adams
                  Votes:
                  1 Vote for this issue
                  Watchers:
                  11 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration