Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-23469

titleEditableSiteType property not properly managed

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.1
    • Fix Version/s: 10.0
    • Component/s: Site Info
    • Labels:
    • Property addition/change required:
      Yes

      Description

      If you have 3 site types in Sakai, course, project and other, and set the property value to:

      titleEditableSiteType=project

      You will be able to edit the title of every site of type project and other, because of this code at https://source.sakaiproject.org/svn//site-manage/trunk/site-manage-tool/tool/src/java/org/sakaiproject/site/tool/SiteAction.java

      private boolean siteTitleEditable(SessionState state, String site_type)

      { return site_type != null && (!site_type.equals((String) state.getAttribute(STATE_COURSE_SITE_TYPE)) || (state.getAttribute(TITLE_EDITABLE_SITE_TYPE) != null && ((List) state.getAttribute(TITLE_EDITABLE_SITE_TYPE)).contains(site_type))); }

      I think the correct code should be this:

      private boolean siteTitleEditable(SessionState state, String site_type)

      { return site_type != null && ((state.getAttribute(TITLE_EDITABLE_SITE_TYPE) != null && ((List) state.getAttribute(TITLE_EDITABLE_SITE_TYPE)).contains(site_type))); }

      Property info.

      1. Sites with non-editable title (by site type)
      2. Example: course - course sites will have read only title.
      3. Set as empty "site.type.titleNotEditable=", every site title would be modified.
      4. Default: course
        #site.type.titleNotEditable=course,project

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  aaronz Aaron Zeckoski (Inactive)
                  Reporter:
                  jjmerono@um.es Juan José Meroño Sánchez
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code