Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-23673

Portal more site view incorrect display

    Details

    • 2.9 Status:
      Resolved

      Description

      If you set portal.use.dhtml.more=false and the user don't have permissions to add sites, in the more site tab you don't see any button in the top right corner.
      Looking at the code you could see this in https://source.sakaiproject.org/svn/portal/trunk/portal-render-engine-impl/pack/src/webapp/vm/neoskin/includeTabs.vm

      #if (${tabsSites.worksiteToolUrl})
      <ul id="otherSitesMenu">
      <li><a id="allSites" href="${tabsSites.worksiteToolUrl}?sakai_nav_minimized=true&sakai.state.reset=true"><span>${rloader.sit_allsites}</span></a></li>
      <li><a id="newSite" href="${tabsSites.worksiteToolUrl}?sakai_nav_minimized=true&panel=Shortcut&sakai_action=doNew_site&sakai.state.reset=true"><span>${rloader.sit_newsite}</span></a></li>
      #if (${tabsSites.prefsToolUrl})
      <li><a href="${tabsSites.prefsToolUrl}?sakai_nav_minimized=true"><span>${rloader.sit_preferences}</span></a></li>
      #end
      <li id="otherSiteCloseW">
      <a href="#" onclick="closeDrawer()" title="${rloader.sit_othersitesclose}"><span>X</span><span class="skip">${rloader.sit_othersitesclose}</span></a>
      </li>
      </ul>
      #end

      So the complete otherSitesMenu is hide by the worksiteToolUrl condition, but only the add new site options would be control by this condition. The code should be like:

      <ul id="otherSitesMenu">
      <li><a id="allSites" href="${tabsSites.worksiteToolUrl}?sakai_nav_minimized=true&sakai.state.reset=true"><span>${rloader.sit_allsites}</span></a></li>
      #if (${tabsSites.worksiteToolUrl})
      <li><a id="newSite" href="${tabsSites.worksiteToolUrl}?sakai_nav_minimized=true&panel=Shortcut&sakai_action=doNew_site&sakai.state.reset=true"><span>${rloader.sit_newsite}</span></a></li>
      #end
      #if (${tabsSites.prefsToolUrl})
      <li><a href="${tabsSites.prefsToolUrl}?sakai_nav_minimized=true"><span>${rloader.sit_preferences}</span></a></li>
      #end
      <li id="otherSiteCloseW">
      <a href="#" onclick="closeDrawer()" title="${rloader.sit_othersitesclose}"><span>X</span><span class="skip">${rloader.sit_othersitesclose}</span></a>
      </li>
      </ul>

        Gliffy Diagrams

          Zeplin

            Attachments

            1. moreok.png
              moreok.png
              25 kB
            2. no buttons more site view.png
              no buttons more site view.png
              45 kB
            3. SAK-23673.patch
              2 kB

              Issue Links

                Activity

                  People

                  Assignee:
                  gsilver Gonzalo Silverio
                  Reporter:
                  jjmerono@um.es Juan José Meroño Sánchez
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration