Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-23825

CourseManagementGroupProvider error in getUserRolesForGroup

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.2, 10.0
    • Fix Version/s: 10.1, 11.0
    • Component/s: Providers
    • Labels:
    • 10 status:
      Resolved
    • 2.9 Status:
      Merge

      Description

      The preferred role is not checked properly.

      Check this change:

      https://source.sakaiproject.org/viewsvn/providers/trunk/cm-authz-provider/src/java/org/sakaiproject/coursemanagement/impl/provider/CourseManagementGroupProvider.java?r1=79984&r2=83968

      The first loop is not properly changed, see the second loop.

      Before the change:

      String existingRole = userRoleMap.get(userEid);

      After the change:

      String existingRole = entry.getValue();

      That's wrong !!

      In the second loop the change is well done !!

      The consecuence is that the preferred role is not calculated properly in the getUserRolesForGroup method.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  buckett Matthew Buckett
                  Reporter:
                  jjmerono@um.es Juan José Meroño Sánchez
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code