Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-25312

TA's can see students not enrolled in their sections/groups.

    Details

    • 10 status:
      Resolved
    • 2.9 Status:
      Resolved
    • Test Plan:
      Hide

      IMPORTANT: In order to test this, you need to add the site level permission 'asn.grade' to the ta role.

      1- Log in as instructor
      2- Create a course site with: 'Spring 2013' and select all group sections from 'SMPL101 Spring 2013 (SMPL101 Spring 2013) Lecture'. Make sure you add the 'Assignments' tool to the site.
      3- Access the site, go to assignments and grant the 'Grade assignments submission(s)' to the ta role.
      4- Add an assignment for the whole site (Select 'Display to site').
      5- Logout
      6- Log in as user 'ta' (This user is only enrolled in 3 of the 6 sections in the site we created before).
      7 - Go to the site, go to assignments and clic on 'grade' under the assignment we created before.
      8 - 'ta' user is viewing all students from the site, even the ones not enrolled in his/her sections.

      Show
      IMPORTANT: In order to test this, you need to add the site level permission 'asn.grade' to the ta role. 1- Log in as instructor 2- Create a course site with: 'Spring 2013' and select all group sections from 'SMPL101 Spring 2013 (SMPL101 Spring 2013) Lecture'. Make sure you add the 'Assignments' tool to the site. 3- Access the site, go to assignments and grant the 'Grade assignments submission(s)' to the ta role. 4- Add an assignment for the whole site (Select 'Display to site'). 5- Logout 6- Log in as user 'ta' (This user is only enrolled in 3 of the 6 sections in the site we created before). 7 - Go to the site, go to assignments and clic on 'grade' under the assignment we created before. 8 - 'ta' user is viewing all students from the site, even the ones not enrolled in his/her sections.

      Description

      From SAK-8160 (Section-aware Assignments), in assignments, a TA should only have access to the students enrolled in the same sections/groups as the TA. That jira described how assignments should handle section awarness "2. TAs to view / grade / download assignments submitted by their group members.". In SAKAI 2.7 it was working that WAY.

      We recently updated to SAKAI 2.9 and found out that the behaviour has changed. We think that it was unintended. After looking through the code, we think that the change was introduced in SAK-18426 (Member role allowed to Grade but cannot see student submission listed unless granted with "all.groups" permission.)

      SAK-18426 was describing a different scenario. Assginments didn't work as they expected in sites without sections so a change was introduced that is now affecting the original section awareness design. We can see in the description of the jira that their problem could be solved granting 'asn.all.groups' or granting 'asn.grade' permission in the site's realm (not in the group's realm) but instead a code change was introduced that now is affecting how section awareness works.

      Is there any reason why it should be working the way it is right now? Can anyone think about any other implications for other type of sites?

      Please watch the video to better understand the problem: https://aulavirtual.um.es/access/content/group/e2968dfa-2579-4afb-b87d-d6aacb502846/SAK-25312%20-%20TAs%20see%20all%20students/SAK-25312%20-%20TAs%20see%20all%20students.html

        Gliffy Diagrams

          Zeplin

            Attachments

            1. assignments_ta_perms.png
              assignments_ta_perms.png
              131 kB
            2. Captura_de_pantalla_111413_040121_PM.jpg
              Captura_de_pantalla_111413_040121_PM.jpg
              303 kB
            3. permissions.jpg
              permissions.jpg
              220 kB
            4. SAK-25312.patch
              0.7 kB
            5. sak-25312 - ta view.jpg
              sak-25312 - ta view.jpg
              288 kB

              Issue Links

                Activity

                  People

                  Assignee:
                  zqian Zhen Qian
                  Reporter:
                  jmariano Jose Mariano Lujan
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration