Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-25363

Editing external tool page name from toolOrder breaks the page

    Details

      Description

      When you add an external tool to a site from following step, and then, edit that page name from pageOrder tool, you click on the tool with the newly changed name, instead of launching the external tool, it just load the site within the frame as per the screenshot.

      I did it on the nightly trunk build as of today. Here is how I reproduce it:

      1. create a course site.
      2. go to newly created site -> Site Info -> External Tools
      3. click on Tools Available in System -> Add External Tool to System to add an external tool
      4. click on Tools Added to Sites -> Add Available Tool to Site -> select the external tool -> check the checkbox of Add Site Link -> click save
      5. Click on the added tool in the left navigation panel, you can load the external page in the iframe.[Good]

      so far so good. Next is to produce the issue:

      6. Back to Site Info -> Page Order -> find the external tool you added in step 4 and change its name
      7. The name was updated in the left panel, but when you click on the tool, you load the whole site in the iframe instead of expected external page.[BAD]

        Gliffy Diagrams

          Zeplin

            Attachments

            1. 1-Tool-Created.png
              1-Tool-Created.png
              53 kB
            2. 2-pageOrder-changeToolName.png
              2-pageOrder-changeToolName.png
              66 kB
            3. 3-notUpdatedInConfig.png
              3-notUpdatedInConfig.png
              63 kB
            4. 4-updateOptionsNotFullyWorked.png
              4-updateOptionsNotFullyWorked.png
              64 kB
            5. Broken-externalTools.png
              Broken-externalTools.png
              181 kB
            6. Normal-externalTools.png
              Normal-externalTools.png
              348 kB
            7. SAK-25363-source-undefined.png
              SAK-25363-source-undefined.png
              354 kB
            8. Screen Shot 2014-01-29 at 10.22.26 AM.png
              Screen Shot 2014-01-29 at 10.22.26 AM.png
              75 kB
            9. trunk-r131705.png
              trunk-r131705.png
              85 kB

              Issue Links

                Activity

                  People

                  Assignee:
                  csev Charles Severance
                  Reporter:
                  yq12 Yuanhua Qu
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration