Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-25823

JSF tools store the ResourceLoader in the Session (as "msgs")

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: OPEN
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 10.0
    • Fix Version/s: None
    • Component/s: JSF
    • Labels:

      Description

      Pretty much all JSF tools store their entire ResourceLoader in the ToolSession attributes under "msgs". This bloats the size of the sessions.

      This seems to be caused by the following:
      <jsp:useBean id="msgs" class="org.sakaiproject.util.ResourceLoader" scope="session">

      faces-config:
      <managed-bean>
      <description>Dynamic Resource Bundle Loader</description>
      <managed-bean-name>msgs</managed-bean-name>
      <managed-bean-class>org.sakaiproject.util.ResourceLoader</managed-bean-class>
      <managed-bean-scope>session</managed-bean-scope>
      <managed-property>
      <description>Bundle baseName</description>
      <property-name>baseName</property-name>
      <value>calendar</value>
      </managed-property>
      </managed-bean>

      Not sure how safe it is to take this out of session state but no other tools cache the ResourceLoaders so it is unlikely that it is needed.

      Probably the fix would be to change it to:
      <managed-bean-scope>request</managed-bean-scope>
      and
      scope="request" (or omit this)

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  ern Earle R Nietzel
                  Reporter:
                  aaronz Aaron Zeckoski (Inactive)
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:

                      Git Integration