Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-26059

getAll/Complete cache: BaseCalendarService

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.9.3, 10.0
    • Fix Version/s: 10.0, 11.0
    • Component/s: Calendar
    • Labels:
      None
    • 10 status:
      Resolved

      Description

      See KNL-1223
      Need to remove the use of complete/getAll caching

      m_calendarCache BaseCalendarService.getCalendars()

      hilariously, this method calls:
      calendars = m_storage.getCalendars();

      which runs this:
      List getCalendars()

      { return super.getAllContainers(); }

      which is:
      "select XML from " + table

      Basically a select all.

      Appears to be only used in the cover:
      org.sakaiproject.calendar.cover.CalendarService

      Suggest we simple eliminate this method entirely.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

              is depended on by

              Bug - A problem which impairs or prevents functionality of the product. SAK-39355 Sakai getAll caching is dangerous and cannot be supported by the Java cache standard (JSR-107)

              • Critical - Crashes, loss of data, severe memory leak, need functionality ASAP in production.
              • CLOSED

              Bug - A problem which impairs or prevents functionality of the product. SAK-26079 Schedule tools does not display interface for adding events

              • Blocker - Blocks development and/or testing work, production could not run without this feature working correctly.
              • Verified
              relates to

              Bug - A problem which impairs or prevents functionality of the product. SAK-26085 CalendarService depends on a Threadlocal for lookup, should be changed to a cache

              • Blocker - Blocks development and/or testing work, production could not run without this feature working correctly.
              • RESOLVED

                Activity

                  People

                  Assignee:
                  aaronz Aaron Zeckoski (Inactive)
                  Reporter:
                  aaronz Aaron Zeckoski (Inactive)
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration