Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-27252

Modify entityprovider for getting profile image when in a worksite

    XMLWordPrintable

    Details

    • Type: Task
    • Status: CLOSED
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.7.1, 2.8.0
    • Fix Version/s: 2.7.1, 2.8.0
    • Component/s: Profile
    • Labels:
      None

      Description

      The change in PRFL-394 broke the ability to get a profile image via the entity provider as it makes a call to get the current siteId, which fails when called in an entity provider because it has no knowledge of the current site.

      Suggest adding another parameter to the entityprovider URL that gives the siteId, eg:
      /direct/profile/<userid>/image/<siteid>
      /direct/profile/<userid>/image/thumb/<siteid>
      /direct/profile/<userid>/<siteid>

      If siteid is present, the permissions for the current user are looked up for the given site and checked against the permissions if the rest of the permissions checks fail (ie is friend, is image allowed etc)

      This should not introduce any security issues.

      If a user cannot normally access a user's image, say, because they are not connected, but can when in a site because they have the appropriate permission, then this is perfectly reasonable as they are expressly allowed to do this via their permissions in that site.

      If a user is already connected, this will be caught earlier and they will be allowed. If a user is not connected and not allowed then they won't be allowed to see it.

      If a user has permissions to see the image in one site (say, because they are an instructor) but not another (becuase they are a student) then even if they craft the URL to the site they are allowed to see the image in and get the image, this is also fine because overall, they are allowed to see the image somewhere so there should be no privacy concerns.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  steve.swinsburg Steve Swinsburg
                  Reporter:
                  steve.swinsburg Steve Swinsburg
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code