Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-28004

Updated MD5Encoder class in dav for Tomcat 7.0.56+

    Details

    • Type: Task
    • Status: CLOSED
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.4 [Tentative], 10.3, 11.0
    • Component/s: WebDAV
    • Labels:
      None

      Description

      dav uses some tomcat classes, and occasionally these seem to change even within minor versions.

      Tomcat 7.0.55 > 7.0.56 changed MD5Encoder from org.apache.catalina.util.MD5Encoder to org.apache.tomcat.util.security.MD5Encoder, so dav needs this code change if/when Sakai updates to Tomcat 7.056+

      It might be better to find another MD5Encoder not part of tomcat, as we've been bitten by incompatible Tomcat changes across minor versions before.

      Index: dav/dav/src/java/org/sakaiproject/dav/DavServlet.java
      ===================================================================
      — dav/dav/src/java/org/sakaiproject/dav/DavServlet.java (revision 311513)
      +++ dav/dav/src/java/org/sakaiproject/dav/DavServlet.java (working copy)
      @@ -117,7 +117,7 @@
      import javax.xml.parsers.ParserConfigurationException;

      import org.apache.catalina.util.DOMWriter;
      -import org.apache.catalina.util.MD5Encoder;
      +import org.apache.tomcat.util.security.MD5Encoder;
      import org.apache.catalina.util.RequestUtil;
      import org.apache.catalina.util.XMLWriter;
      import org.apache.commons.logging.Log;

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  smarquard Stephen Marquard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code