Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-28047

Accents don't work in Upload All / Download All zip filenames from Windows ZIP

    XMLWordPrintable

    Details

    • 21 Status:
      Resolved
    • 20 status:
      Please Merge
    • 19 status:
      Please Merge
    • Test Plan:
      Hide
      1. As instructor, create an assignment
      2. As a student, submit the assignment
      3. As instructor, access the submissions list
      4. Click download all, select "All", click download
      5. In the zip file, add a file with accents in the filename under "Feedback Attachment(s)" for the submission (see Jira attachments)
      6. In the submissions list, click upload all, select the zip, select "All", click upload
      7. Expect feedback attachments to be added to submissions, and submissions list to be displayed. Instead it goes back to the upload all page and a stack trace is printed in the logs, submissions are not changed.

      Similar issue with accents in group names:

      1. Create a group in Site Info with accents in the name (ex. "Team éàèç")
      2. Assign a group submission assignment to this group
      3. Submit as a student member of the group
      4. As instructor, go to the download all page, select "All" and click download
      5. Add a feedback item to the "Feedback Attachment(s)" folder for the group in the zip
        • Note the folder name has accents in it
      6. Click on upload all, select the modified zip and "All" and click upload
      7. Expect feedback attachments to be added to submissions, and submissions list to be displayed. Instead it goes back to the upload all page and a stack trace is printed in the logs, submissions are not changed.
      Show
      As instructor, create an assignment As a student, submit the assignment As instructor, access the submissions list Click download all, select "All", click download In the zip file, add a file with accents in the filename under "Feedback Attachment(s)" for the submission (see Jira attachments) In the submissions list, click upload all, select the zip, select "All", click upload Expect feedback attachments to be added to submissions, and submissions list to be displayed. Instead it goes back to the upload all page and a stack trace is printed in the logs, submissions are not changed. Similar issue with accents in group names: Create a group in Site Info with accents in the name (ex. "Team éàèç") Assign a group submission assignment to this group Submit as a student member of the group As instructor, go to the download all page, select "All" and click download Add a feedback item to the "Feedback Attachment(s)" folder for the group in the zip Note the folder name has accents in it Click on upload all, select the modified zip and "All" and click upload Expect feedback attachments to be added to submissions, and submissions list to be displayed. Instead it goes back to the upload all page and a stack trace is printed in the logs, submissions are not changed.

      Description

      The encoding is not handled correctly in either case for zip files containing accented characters.

      Traditionally, the Zip format uses CP437 character encoding for file names, which is not sufficient for many international character sets. Different tools have developped different approaches to solving this issue, which makes trying to parse zips from unknown tools complicated.

      Non-UTF-8 encoding in ZIP file
      Apache Commons Compress

        Gliffy Diagrams

          Zeplin

            Attachments

            1. 04092021_results.gif
              04092021_results.gif
              49 kB
            2. 6April2021_Download_Upload.gif
              6April2021_Download_Upload.gif
              42 kB
            3. malformed.txt
              6 kB
            4. Nightly_Assignments_2014-11-03_16-26-10.png
              Nightly_Assignments_2014-11-03_16-26-10.png
              42 kB
            5. Screen Shot 2021-03-31 at 1.57.47 PM.png
              Screen Shot 2021-03-31 at 1.57.47 PM.png
              73 kB
            6. test accents_20210331133139.zip
              59 kB
            7. Test Download_20210406191442.zip
              12 kB
            8. Test Download.zip
              18 kB
            9. testéèàçê.txt
              0.0 kB

              Activity

                People

                Assignee:
                agschmidt Andrea Schmidt
                Reporter:
                curtisvo Curtis van Osch
                Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration