Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-28146

org.sakaiproject.portal.util.ToolUtils.isInlineRequest() fails when passed a ActiveToolComponent$MyActiveTool$WrappedRequest

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.2
    • Fix Version/s: 11.0
    • Component/s: Portal
    • Labels:
      None
    • 10 status:
      Won't Fix

      Description

      This portal library code to detect if a request is inline:

      org.sakaiproject.portal.util.ToolUtils.isInlineRequest()

      Fails when passed a ActiveToolComponent$MyActiveTool$WrappedRequest since the wrapped request messes with the getPathInfo() method.

      So the better choice is to go to getRequestURI() instead which is dutifly passed through a WrappedRequest.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  csev Charles Severance
                  Reporter:
                  csev Charles Severance
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration