Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-28615

Sitestats build fails after upgrading to surefire plugins 2.7+ and site plugin 2.1+

    XMLWordPrintable

    Details

    • Previous Issue Keys:
      STAT-298

      Description

      After upgrading the purepoms-2.7.x and 2.8.x to use the maven-surefire-plugin 2.8, maven-surefire-report plugin 2.8 and the maven-site-plugin 2.2 (now required when including surefire plugins 2.7+) Sitestats will fail with the following error:

      [INFO] Surefire report directory: /home/arwhyte/svn/sitestats/branches/sitestats-2.1.x/sitestats-impl/target/surefire-reports
      [INFO] ------------------------------------------------------------------------
      [ERROR] FATAL ERROR
      [INFO] ------------------------------------------------------------------------
      [INFO] includes1 has null value
      [INFO] ------------------------------------------------------------------------
      [INFO] Trace
      java.lang.NullPointerException: includes1 has null value
      at org.apache.maven.surefire.booter.PropertiesWrapper.addList(PropertiesWrapper.java:282
      . . . .

      This is due to a failure to specify a specific <build> directive for the perftest <profile> in the impl pom. Instead it's specified outside and the property <perftests.includes /> (with no value) is selected by Maven when it attempts to build the project.

      However, if you activate the profile -Pperftests specified in the Impl pom the build fails with test failures.

      <profiles>
      <profile>
      <!-- Execute performance tests (instead) -->
      <id>perftests</id>
      <properties>
      <perftests.includes>**/*TestPerf.java</perftests.includes>
      </properties>
      </profile>
      </profiles>

      The workaround from a release perspective is to separate out by the perftests build profile from the default profile so that the absence of a <perftests.includes> value in the base pom doesn't break the build when trying to perform a release. Still, this is not a satisfactory state of affairs since running -Pperftests results in a build failure. We should figure out why the perfe tests fail.

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                arwhyte Anthony Whyte
                Reporter:
                arwhyte Anthony Whyte
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration