Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-29180

Refactor handler code so PDAHandler can be removed

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.4
    • Fix Version/s: 11.0
    • Component/s: Portal
    • Labels:
      None
    • Property addition/change required:
      Yes

      Description

      Because of how page inlinining developed in Sakai over the years, all of the clever code to do inlining and inline decision making was developed and used in the PDAHandler.java code. As inlining was added to SiteHandler.java, we just used this code from PDAHandler.java. With the impending removal of PDAHandler.java in SAK-29115 we must make SiteHandler.java independent of PDHandler.java.

      Deleted/Obsolete Properties:

      gatewayPdaSiteUrl
      portal.pda.autoredirect
      portal.tablets.use.mobile
      portal.frameset

      This also renames some Sakai properties:

      Legacy Names:

      portal.pda.bypass
      portal.pda.bypass.query
      portal.pda.bypass.type
      portal.pda.iframesuppress

      New Names:

      portal.bypass
      portal.bypass.query
      portal.bypass.type
      portal.iframesuppress

      The code in Sakai-11 will accept both the legacy and new property names for the iframe bypass/control. If both are present, the new name will have precedence. The legacy names will be deleted in Sakai-12.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  csev Charles Severance
                  Reporter:
                  csev Charles Severance
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code