Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-29189

Using multiple tabs in Forums fails to post message

    XMLWordPrintable

    Details

    • Test Plan:
      Hide

      Topic 1 - Open the topic
      Topic 1 - Open the conversation
      Topic 1 - Click "Reply" for the first message
      Topic 2 - Open the topic
      Topic 2 - Open the conversation
      Topic 2 - Click Reply
      Topic 1 - Post (should be successful)
      Topic 2 - Post (should be successful)
      Topic 1 - Click Reply
      Topic 2 - Click Reply
      Topic 1 - Click Post (It will fail, returning to Forums "home" screen)
      Topic 2 - Click Post (It should be successful)

      Show
      Topic 1 - Open the topic Topic 1 - Open the conversation Topic 1 - Click "Reply" for the first message Topic 2 - Open the topic Topic 2 - Open the conversation Topic 2 - Click Reply Topic 1 - Post (should be successful) Topic 2 - Post (should be successful) Topic 1 - Click Reply Topic 2 - Click Reply Topic 1 - Click Post (It will fail, returning to Forums "home" screen) Topic 2 - Click Post (It should be successful)

      Description

      When using multiple tabs to post into two different topics a user can find their message irretrievably lost when they click post. In previous versions of Sakai they would see an annoying alert that they were using multiple tabs, but it they would still be able to copy their message and attempt again after resetting the tool. Now, if there's a problem when they click Post it will simply return them to the default tool state and their message is gone.

      I've included a test plan that will reproduce the problem reliably.

      This new behavior is related to SAK-27998. What is happening is that sometimes the "currentTopicId" parameter in the HTML is wrong when the Forums tool gets confused. When "currentTopicId" doesn't match the TopicId of the message being replied to, it fails to the home screen.

      That's good in the sense that it's preventing client-side parameter tampering, but obviously it's bad because the state information supplied to the client should never be initialized to values that are invalid (e.g. the currentTopicId value doesn't match the topic of the currentMessageId value). This is what seems to be happening under certain circumstances.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  maintenanceteam Core Team
                  Reporter:
                  ansorgej John Ansorge
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:

                    Git Source Code