Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-29301

Editing "Site Information Display" in Home changes "Custom Title" property to false for every Home tool

    XMLWordPrintable

    Details

      Description

      When some user edits any web content tool placed in Home, like Site Information Display, Home tool's property "Custom Title" changes to true.

      This makes that the title of every Home tool (i.e. Synaptic Announcements, Messages & Forums, Calendar, etc) is saved with their current text and does not change anymore when user changes its language.

      Just moving a line in the code to avoid this change when PortletIFrame edition is done inside Home would fix the issue:

      In web/web-portlet/src/java/org/sakaiproject/portlets/PortletIFrame.java:

      try
      {
      Site site = SiteService.getSite(toolConfig.getSiteId());
      SitePage page = site.getPage(toolConfig.getPageId());
      //page.setTitleCustom(true);

      // for web content tool, if it is a site page tool, and the only tool on the page, update the page title / popup.
      if (toolConfig != null && ! SPECIAL_WORKSITE.equals(special) && ! SPECIAL_WORKSPACE.equals(special) )
      {
      // if this is the only tool on that page, update the page's title also
      if ((page.getTools() != null) && (page.getTools().size() == 1))
      {
      page.setTitleCustom(true);
      String newPageTitle = request.getParameter(FORM_PAGE_TITLE);
      ...

      More logic could be added, like changing Custom Title only if the title has been changed when saving.

        Gliffy Diagrams

          Attachments

          1. screenshot-1.png
            screenshot-1.png
            84 kB
          2. screenshot-2.png
            screenshot-2.png
            59 kB
          3. screenshot-3.png
            screenshot-3.png
            91 kB

            Issue Links

              Activity

                People

                • Assignee:
                  csev Charles Severance
                  Reporter:
                  daniel.merino Daniel Merino Echeverría
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code