Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-29690

Allow LTI tools to go fullscreen

    Details

    • 11 status:
      Resolved

      Description

      As described at:

      http://stackoverflow.com/questions/14151899/when-using-video-js-why-doesnt-the-full-screen-button-work-inside-an-iframe

      some HTML pages are unable to go full-screen (typically video playback) if the iframe does not include the allowfullscreen attribute.

      This should be set by default for LTI iframes, or if that's not desireable, at least an option per-tool or per-placement.

      Index: basiclti/basiclti-portlet/src/java/org/sakaiproject/portlets/IMSBLTIPortlet.java
      ===================================================================
      --- basiclti/basiclti-portlet/src/java/org/sakaiproject/portlets/IMSBLTIPortlet.java	(revision 320142)
      +++ basiclti/basiclti-portlet/src/java/org/sakaiproject/portlets/IMSBLTIPortlet.java	(working copy)
      @@ -252,7 +252,7 @@
       					text.append("height=\""+frameHeight+"\" \n");
       					text.append("width=\"100%\" frameborder=\"0\" marginwidth=\"0\"\n");
       					text.append("marginheight=\"0\" scrolling=\"auto\"\n");
      -					text.append("src=\""+iframeUrl+"\">\n");
      +					text.append("src=\""+iframeUrl+"\" allowfullscreen=\"true\" webkitallowfullscreen=\"true\" mozallowfullscreen=\"true\">\n");
       					text.append(rb.getString("noiframes"));
       					text.append("<br>");
       					text.append("<a href=\""+iframeUrl+"\">");
      

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  csev Charles Severance
                  Reporter:
                  smarquard Stephen Marquard
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration