Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-29823

Site type title not editable sakai.property not being obeyed

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.0
    • Fix Version/s: 10.6, 11.0
    • Component/s: Site Info
    • Labels:
      None
    • 10 status:
      Resolved
    • Test Plan:
      Hide

      1) Do not set site.type.titleNotEditable in sakai.properties (default is course)
      2) Do not set courseSiteType in sakai.properties (default is course)
      3) Create a course site
      4) Notice title is editable, when you would expect that it should not be editable according to the defaults of the sakai.properties

      Show
      1) Do not set site.type.titleNotEditable in sakai.properties (default is course) 2) Do not set courseSiteType in sakai.properties (default is course) 3) Create a course site 4) Notice title is editable, when you would expect that it should not be editable according to the defaults of the sakai.properties

      Description

      After stepping through the code in debug mode, the properties are actually loaded properly. The problem is the implementation in the velocity template.

      Whoever updated the property and loading code didn't check the velocity template to see how it was implemented to obey the property. The conditional was effectively the opposite of what it needs to be:

      #if (!$!existingSite || $!siteTitleEditable)

      The code shouldn't care if the site exists already or not, we want it to obey the property regardless. Also, it shouldn't be rendering the input field if the site title is NOT editable; it should only render it if it IS editable:

      #if ($siteTitleEditable)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  bjones86 Brian Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code