Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-29935

The support.email property isn't defined in sakai.properties files, change to mail.support

    Details

    • 11 status:
      Resolved
    • Property addition/change required:
      Yes
    • Test Plan:
      Hide

      Ensure you do not have support.email set in sakai.properties
      use reset-pass with siteManage.validateNewUsers=false in sakai.properties
      use reset-pass with siteManage.validateNewUsers=true in sakai.properties
      before responding to the email, use reset-pass a second time
      with siteManage.validateNewUsers=true in sakai.properties
      configure a "New Account" tool instance with a tool property: "validate-through-email", and test it
      add an unofficial participant to the site (who isn't already in the system)
      Verify you don't get any bug reports and that your mail.support address is used as appropriate
      I think that should be a pretty thorough test of all email functionality in reset-pass / account-validator. There's also a "accountValidator.sendLegacyLinks" property, for some old behavior (sends 'reset-pass' users, 'add participants' users, as well as 'new account' users to the same RSF page; it was getting to be impossible to support, so I split everything up at some point in Sakai 2.9, and I strongly recommend discontinuing support for that property).

      Show
      Ensure you do not have support.email set in sakai.properties use reset-pass with siteManage.validateNewUsers=false in sakai.properties use reset-pass with siteManage.validateNewUsers=true in sakai.properties before responding to the email, use reset-pass a second time with siteManage.validateNewUsers=true in sakai.properties configure a "New Account" tool instance with a tool property: "validate-through-email", and test it add an unofficial participant to the site (who isn't already in the system) Verify you don't get any bug reports and that your mail.support address is used as appropriate I think that should be a pretty thorough test of all email functionality in reset-pass / account-validator. There's also a "accountValidator.sendLegacyLinks" property, for some old behavior (sends 'reset-pass' users, 'add participants' users, as well as 'new account' users to the same RSF page; it was getting to be impossible to support, so I split everything up at some point in Sakai 2.9, and I strongly recommend discontinuing support for that property).

      Description

      In the default.sakai.properties file:

      # Sets the 'from' email address and name for password reset emails (if not set, falls back to mail.support)
      # accountValidator.checkValidations.fromEmailAddress=
      # accountValidator.checkValidations.fromEmailName=
      

      And you can find the mail.support property:

      # Email support address used in incoming email rejection messages.
      # DEFAULT: none (null)
      # mail.support=
      

      The reset password tool uses support.email property.
      If support.email isn't defined, then the e-mail notification doesn't work. This property doesn't appear in any sakai.properties files.

      Are both the same property? In that case, Reset Pass Tool should use mail.support instead of support.email.
      Or, are they differents? In that case, the properties file should define support.email with an explanation of usage.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  juanarcadio Juan Arcadio Martinez Carceles
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code