Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-30009

Delegated Access functionality is broken with the fix SAK-28186

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 10.5
    • Fix Version/s: 10.6, 11.0
    • Component/s: DelegatedAccess
    • Labels:
      None
    • 10 status:
      Resolved

      Description

      Delegated Access functionality is broken with the fix SAK-28186

      There were 2 files modified:

      1. delegatedaccess/impl/src/java/org/sakaiproject/delegatedaccess/logic/ProjectLogicImpl.java - This file had an issue where Concurrent hashmaps throw NPE when storing null values https://jira.sakaiproject.org/browse/SAK-28988. Fix for this has been merged SAK-28988 into the Sakai 10.x Subversion maintenance branch

      2. delegatedaccess/impl/src/java/org/sakaiproject/delegatedaccess/dao/impl/DelegatedAccessDaoImpl.java - This file was modified mostly to use list of arguments (ArrayList) as an input to bind to the query method of the JDBCTemplate. As a result of the change , getNodesBySiteRef method is totally broken and is not returning right results.

      e.g getNodesBySiteRef - The sql use in this method is as below:
      select.hierarchyNode = Select ID, title From HIERARCHY_NODE_META where title in and hierarchyId = ? and isDisabled = 0

      But when values are added in List, hierarchyId is added first and which as a result does not return any data.

      And what was the intent of changes in this class as it has also removed given below changes which was the reported JIRA issue.

      inParams += "'" + subSiteRefs[i].replace("'", "''") + "'"; //escape apostrophe

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  baholladay Bryan Holladay
                  Reporter:
                  sverma Seema Verma
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration