Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-29824 Invalid numberofsubmitters in assignment submission XML
  3. SAK-30087

Clean up useless numberof attributes from assignment submissions

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.0
    • Fix Version/s: 10.7
    • Component/s: Assignments
    • Labels:
      None
    • Test Plan:
      Hide

      I would test anything that might access the attributes removed on a submission.

      Such as submission count, logs, number of submitters (for a group submission) feedback attachments and submittedattachments. I've tested most of these on the submission confirmation page, on the resubmission page and on the grading page and they seem good but there's a change something isn't working so should be tested out.

      Show
      I would test anything that might access the attributes removed on a submission. Such as submission count, logs, number of submitters (for a group submission) feedback attachments and submittedattachments. I've tested most of these on the submission confirmation page, on the resubmission page and on the grading page and they seem good but there's a change something isn't working so should be tested out.

      Description

      It was noted in SAK-29824 that when numberofsubmitters was incorrect (which happens for some reason) that there can be permission problems and other errors. I looked and this value was only used as an iterator for the loop so seems completely useless. While looking at this 5 other attributes also have the same patterns, so I removed all of them.

      Ideally the old XML would be cleaned up too but it doesn't really matter if they're there or not.

      Cleans up

      numberofsubmissions
      numberoflogs
      numberofgrades
      numberofsubmitters
      numberoffeedbackattachments
      numberofsubmittedattachments

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  ncaidin Neal Caidin
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration