Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-30185

JavaScript regression in assignments

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 11.0
    • Fix Version/s: 11.0
    • Component/s: Assignments
    • Labels:

      Description

      I've discovered that returning false inside a method call from an onclick is not functionally equivalent to returning false in the onclick itself. This is causing some strange behaviour in certain browsers in certain conditions.

      The solution is to remove the 'returnFalse' parameter from the 'submitForm' JavaScript function, and instead return false explicitly in the onclick where required.

      Some symptoms of this:

      1) In Chrome and Opera, clicking the 'Download All' for an assignment does nothing; the page refreshes and you are not presented with the 'Download All' UI.
      2) In Firefox (and possibly other browsers), clicking the 'Release Grades' link for an assignment will release the grades, but the checkmarks in the 'Released' column will not be displayed until a manual page refresh is done, or you click the 'Release Grades' link a second time.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  adamm Adam Marshall
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration