Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-30323

General bug fixes/tidyings up of Citations

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.4
    • Fix Version/s: 11.0, 12.0
    • Component/s: Citations
    • Labels:
      None
    • 11 status:
      Resolved
    • Test Plan:
      Hide

      1. Create a reading list, create an h1, give it a description, click Edit on it. The other buttons in the nested reading list area (apart from 'Finish Editing') (e.g., Save, Delete, Add Section) should be disabled.

      2. Create a reading list, import a citation, create an h1, give it a description, create an h2 inside that and give that a description and create an h3 and give that a description, then click save. You should be able to drag a citation to:
      A. the bottom of an h2
      B. the bottom of an h1
      C. beneath a description (if it's at the top)
      At the moment you can't.

      You should not be able to drag a citation to:
      A. inside a description
      At the moment you can.

      3. View a reading list as an admin and you get this error in the logs:

      2016-03-03 14:34:42,788 [ajp-bio-0.0.0.0-8009-exec-33] WARN org.sakaiproject.util.ResourceLoader - bundle 'citations' missing key: 'nested.edit.description.section.button' from: org.sakaiproject.util.ResourceLoader.getString(ResourceLoader.java:472)#
      2016-03-03 14:34:42,805 [ajp-bio-0.0.0.0-8009-exec-33] WARN org.sakaiproject.util.ResourceLoader - bundle 'citations' missing key: 'nested.finish.editing.description.button' from: org.sakaiproject.util.ResourceLoader.getString(ResourceLoader.java:472)

      4/5/6/7. See attached screenshot. The tabs that looked a bit funny in the middle of the screen are now blue buttons in line with the 'Done' button on the page and they are all in alignment (before the tabs were out of alignment). The 'Export' is now a link in the top right of the title on the reading list.

      8. Add an h1 and at the top of the page you were getting an error message '[missing key (mre): citations resource.updated]'. This shouldn't be there anymore.

      9. Create an empty reading and save it and go back into it. It should say 'No citations have been imported yet.'. Manually create a citation. The message should not be there. Delete the citation. The message should be back. Add a citation to a nested section. The message should be absent.

      10. 1. Create a reading list with an h1 and inside that an h2 and inside that an h3. Then import 2 citations and put one inside the h3. Save the list. Edit the list and click Edit on the nested citation. Save the Edit. It should not copy that citation into the unnested list.

      11. Add an h1 and look in eg., Firebug's console and you were seeing an error saying the jquery.js could not be found. This should not be there anymore.

      12. Add a reading list, and a h1, h2 and h3. Save it and go back in to edit it. Click on the arrow and it should expand and the arrow should point down now.

      Show
      1. Create a reading list, create an h1, give it a description, click Edit on it. The other buttons in the nested reading list area (apart from 'Finish Editing') (e.g., Save, Delete, Add Section) should be disabled. 2. Create a reading list, import a citation, create an h1, give it a description, create an h2 inside that and give that a description and create an h3 and give that a description, then click save. You should be able to drag a citation to: A. the bottom of an h2 B. the bottom of an h1 C. beneath a description (if it's at the top) At the moment you can't. You should not be able to drag a citation to: A. inside a description At the moment you can. 3. View a reading list as an admin and you get this error in the logs: 2016-03-03 14:34:42,788 [ajp-bio-0.0.0.0-8009-exec-33] WARN org.sakaiproject.util.ResourceLoader - bundle 'citations' missing key: 'nested.edit.description.section.button' from: org.sakaiproject.util.ResourceLoader.getString(ResourceLoader.java:472)# 2016-03-03 14:34:42,805 [ajp-bio-0.0.0.0-8009-exec-33] WARN org.sakaiproject.util.ResourceLoader - bundle 'citations' missing key: 'nested.finish.editing.description.button' from: org.sakaiproject.util.ResourceLoader.getString(ResourceLoader.java:472) 4/5/6/7. See attached screenshot. The tabs that looked a bit funny in the middle of the screen are now blue buttons in line with the 'Done' button on the page and they are all in alignment (before the tabs were out of alignment). The 'Export' is now a link in the top right of the title on the reading list. 8. Add an h1 and at the top of the page you were getting an error message ' [missing key (mre): citations resource.updated] '. This shouldn't be there anymore. 9. Create an empty reading and save it and go back into it. It should say 'No citations have been imported yet.'. Manually create a citation. The message should not be there. Delete the citation. The message should be back. Add a citation to a nested section. The message should be absent. 10. 1. Create a reading list with an h1 and inside that an h2 and inside that an h3. Then import 2 citations and put one inside the h3. Save the list. Edit the list and click Edit on the nested citation. Save the Edit. It should not copy that citation into the unnested list. 11. Add an h1 and look in eg., Firebug's console and you were seeing an error saying the jquery.js could not be found. This should not be there anymore. 12. Add a reading list, and a h1, h2 and h3. Save it and go back in to edit it. Click on the arrow and it should expand and the arrow should point down now.

      Description

      This is a catch all bucket Jira for any improvements or changes or tidyings up or general bug fixes for the Citations screen. It includes:

      1. Make 'Finish Editing' button more obvious when user clicks 'Edit' on description/title
      2. Correct drag and drop options
      3. Correct missing key errors when you load edit screen.
      4. Change tabs to be buttons and make them align properly/neatly.
      5. Move Export tab to a link in top right of reading list
      6. Change Add Citation from tab to plain text
      7. Make screen look nicer by aligning things more properly
      8. Fix for bug where you add a reading list and a h1 and the error at top of page is : [missing key (mre): citations resource.updated]
      9. 'No citations have been added yet. ' shows even if there are citations
      10. Fix bug where Editing a nested citation copies it into the unnested list.
      11. Fix for bug on 'create citation page' where it cannot find jquery
      12. Arrow does not change when expanding a section

      The test plans are numbered to correspond with this list.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  • Assignee:
                    nickwilson Nick Wilson
                    Reporter:
                    nickwilson Nick Wilson
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Git Integration