Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-30654

Autosave plugin redefines escape, update plugin

    XMLWordPrintable

    Details

    • 11 status:
      Resolved
    • Test Plan:
      Hide

      Test that the Auto Save feature in CK Editor works.
      Test in different browsers, for example Safari.

      If it doesn't work on particular browsers then open a ticket with –
      Against CK Editor Auto Save plug-in (in Github)

      Show
      Test that the Auto Save feature in CK Editor works. Test in different browsers, for example Safari. If it doesn't work on particular browsers then open a ticket with – Against CK Editor Auto Save plug-in (in Github)

      Description

      I got a complaint that a link in Lessons doesn't work. When I investigated I found that the function "escape" is being redefined in

      library/editor/ckextraplugins/autosave/js/extensions.min.js

      It is called from the autosave plugin.

      The redefinition is buggy. It doesn't handle & correctly. Furthermore, it doesn't handle all the kinds of special characters that the normal Javascript definition does. I can (and will) fix lessons to not use escape. However defining a Javascript core function could have unpredictable effects throughout Sakai.

      I suspect simply removing the redefinition of escape would be OK. I think the built-in definition would accomplish what is needed.

      I'm flagging this as blocker even though I don't have any symptoms to report other than one in Lessons that I'll fix. But I think this is too dangerous to allow.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  hedrick Charles Hedrick
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration