Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-30664

portal needs to load jquery-ui.css as well as .js

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.0
    • Fix Version/s: 12.0
    • Component/s: Portal
    • 11 status:
      Resolved

      Description

      This is actually a fix to LSNBLDR-596, and in fact the fix was committed with that Jira. I've made this Jira to let people know that it needs to be tested further. For the fix, see LSNBLDR-596, commit bafd040a5ac82e7eaa78911f0e1c1d8434e46265.in master.

      I'm not entirely sure how to test it. There are patches two places: portalUtils and site.vm. Both patches cause jquery-ui.min.css to be loaded at the same time as jquery-ui.min.js. The first is the one actually used by Samigo in an iframe. Since the problem reported in LSNBLDR-596 is fixed, I'm pretty sure that is fixed. The other one seems to happen for all major page loads. I checked the generated HTML, and it seems right. However I don't know of any actual bugs that it fixes.

      What could break if the patch is wrong? It might fail to load the css. To my knowledge the only place it's actually needed is the case in LSNBLDR-596. That works. It might load it somewhere that it wasn't before, and somehow break markup. Since jquery UI is now loaded on all pages, in theory this could break markup anywhere in Sakai. In practice it's unlikely to do so unless someone used the same classes that jquery UI uses, and there's a conflict. I doubt this will actually happen.

      There's also a pair of cases for portalUtils and site.vm where jquery is already loaded and jquery-ui is not, and the code loads just jquery-ui. I copied the document.write from the other case, so I assume this is OK, but I don't know of any tools that actually use this code.

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                Unassigned Unassigned
                Reporter:
                hedrick Charles Hedrick
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration