Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 12.0 [Tentative]
    • Component/s: Forums Tool
    • Labels:
      None
    • 11 status:
      Merge
    • Test Plan:
      Hide
      • Add Gradebook and Forums to a site
      • Add a gradebook item with some point value
      • Go to forums, forum settings (the default topic is fine) and assign the gradebook item under grading
      • Save the settings

      (Ideally check the database now
      MFR_OPEN_FORUM_T -> DEFAULTASSIGNNAME should have the gradebook ID not a name
      )

      • Verify that the grade item comes up in the menu when editing again.
      • Post to that forum as a student
      • Grade the student
      • Verify the grade is updated in the gradebook without error

      (Ideally check the database now
      MFR_MESSAGE_T -> GRADEASSIGNMENTNAME should have the gradebook ID not a name
      )

      The best test would also verify that old forum values work, but you'd have to modify the database for this. You'd insert the name of the gradebook item in these above tables/column and verify it still functions as expected.

      Additionally, now you should be able to have gradebook items with the same name and also rename gradebook items and not have any problems.

      Show
      Add Gradebook and Forums to a site Add a gradebook item with some point value Go to forums, forum settings (the default topic is fine) and assign the gradebook item under grading Save the settings (Ideally check the database now MFR_OPEN_FORUM_T -> DEFAULTASSIGNNAME should have the gradebook ID not a name ) Verify that the grade item comes up in the menu when editing again. Post to that forum as a student Grade the student Verify the grade is updated in the gradebook without error (Ideally check the database now MFR_MESSAGE_T -> GRADEASSIGNMENTNAME should have the gradebook ID not a name ) The best test would also verify that old forum values work, but you'd have to modify the database for this. You'd insert the name of the gradebook item in these above tables/column and verify it still functions as expected. Additionally, now you should be able to have gradebook items with the same name and also rename gradebook items and not have any problems.

      Description

      Forums uses the old method getAssignments passing the assignment name. It should use the new method to retrieve assignments by ids.

      Part of the issue is that MFR_TOPIC_T and MFR_OPEN_FORUM_T store DEFAULTASSIGNNAME as a text field, so it would either have to still work with the legacy method or just change the column type and run some kind of conversion (preferred).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code