Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-30872

Calendar subscription message has duplicated and is missing parameters

    XMLWordPrintable

    Details

    • 11 status:
      Resolved
    • Test Plan:
      Hide

      click on Publish (Public) the message at the top should not be duplicated and should not show

      {0}

      and

      {1}

      as unreplaced parameters. See screen shot for how it should NOT look!

      Show
      click on Publish (Public) the message at the top should not be duplicated and should not show {0} and {1} as unreplaced parameters. See screen shot for how it should NOT look!
    • Release Notes:
      Sakai - TRUNK - Sakai 17f2de1b0ffafefd66e3adfa8e6d70140ef3a995) - Server ip-172-31-6-159

      Description

      On the Publish (Public) the 'subscription window' text is incorrect. (See screenshot.) The following message should be used.

      The second half of the message is missing and the first part is duplicated. (NB: I may have got the {0} and {1} parameters the wrong way around!)

      Subscription to this calendar in other applications will display all events within a window of plus {0} and minus {1} months. Authentication is not required and all events will potentially be visible to the general public. If this is not desirable then please publish via a private link instead.
      

      On the Publish (private) page the (second) message in the properties file should be

      Subscription to this calendar in other applications will display all events within a window of plus {0} and minus {1} months.
      

      the screenshot (screenshot-2.png) shows the parameters are the wrong way around

      The following two properties should be set in sakai properties, see INFRSTR-345

      # Determine the range for calendar export
      # Number of months from the past required in the export
      calendar.export.previous.months = 6
      # Number of months in the future required in the export
      calendar.export.next.months = 12
      

      I wonder whether the code that reads string property then writes out the message isnt supplying parameters to be substituted?

        Gliffy Diagrams

          Zeplin

            Attachments

            1. 1.png
              1.png
              9 kB
            2. screenshot-1.png
              screenshot-1.png
              23 kB
            3. screenshot-2.png
              screenshot-2.png
              31 kB

              Issue Links

                Activity

                  People

                  Assignee:
                  adamm Adam Marshall
                  Reporter:
                  adamm Adam Marshall
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration