Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-31223

preselected tools in toolOrder.xml do not take effect

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.0, 11.2
    • Fix Version/s: 11.3, 12.0
    • Component/s: Site Info
    • Labels:
      None
    • 11 status:
      Resolved

      Description

      While applying SAK-16600 patch to our installation we found a slight problem:
      When specifying a preselected tool in the file toolOrder.xml for example:

      <tool id="sakai.lessonbuildertool" selected="true"/>

      The selection will not take effect.

      We found it to be due to a simple "copy-paste" mistake in the source code.
      However our copy of the source seemed to be an old branch, therefore, this change might already be integrated in your sakai version.

      For more details a patch called SAK-16600-preselection-fix.patch is attached:

      Index: kernel/kernel-impl/src/main/java/org/sakaiproject/component/impl/BasicConfigurationService.java
      ===================================================================
      — kernel/kernel-impl/src/main/java/org/sakaiproject/component/impl/BasicConfigurationService.java (revision 157)
      +++ kernel/kernel-impl/src/main/java/org/sakaiproject/component/impl/BasicConfigurationService.java (working copy)
      @@ -940,7 +940,7 @@
      */
      public boolean toolGroupIsSelected(String groupName, String toolId)
      {
      - List selList = (List) m_toolGroupRequired.get(groupName);
      + List selList = (List) m_toolGroupSelected.get(groupName);
      if (selList == null)

      { return false; }

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  maintenanceteam Core Team
                  Reporter:
                  ralvarez Raquel Alvarez Ramirez
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration