Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-31697

Tool icon selectors don't all start with "icon-sakai"

    Details

    • 11 status:
      Resolved

      Description

      So there is an issue in that some tools don't start with "icon-sakai", and "icon-" would just be too wide open.

      Alternatives are:

      • adding some additional selectors that restrict where icons can be used
        @if $skin-with-icons {
        	.Mrphs-toolsNav__menuitem--icon,
        	.Mrphs-breadcrumb--icon,
        	ul li .selectedToolTitle i,
        	.removeTool,
        	.Mrphs-sitesNav__submenuitem-icon .toolMenuIcon {
        		@extend .fa-lg;
        		@extend .fa;
        	}
        ....
        }
        
      • changing the name of the selector to add more entropy
        requires changes to the source locations where icons are used.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ern Earle R Nietzel
                  Reporter:
                  ern Earle R Nietzel
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code