Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-31714

portal.include.extrahead not included in embedded tool urls

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: OPEN
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: 10.8 [Tentative], 11.2, 12.0
    • Fix Version/s: None
    • Component/s: Portal
    • Test Plan:
      Hide

      In the sakai.properties for the system add this property

      portal.include.extrahead=<script type="text/javascript">console.log && console.log("EXTRA HEAD")</script>

      This will cause the text EXTRA HEAD to print to the javascript console (ctrl-alt-j in most browsers) so you can see if this is actually loaded or not on that page.

      • Create a new site, add the forums and Lessons Tool
      • In lessons, add content->embed forums
      • Click into the forum and start a conversation

      You should see the text EXTRA HEAD printed in the console on every page, previously it wasn't printed in an embedded forum.

      Show
      In the sakai.properties for the system add this property portal.include.extrahead=<script type="text/javascript">console.log && console.log("EXTRA HEAD")</script> This will cause the text EXTRA HEAD to print to the javascript console (ctrl-alt-j in most browsers) so you can see if this is actually loaded or not on that page. Create a new site, add the forums and Lessons Tool In lessons, add content->embed forums Click into the forum and start a conversation You should see the text EXTRA HEAD printed in the console on every page, previously it wasn't printed in an embedded forum.

      Description

      So in testing, I'm seeing that the feature from SAK-29001 where you can include some extra head code isn't being included on on embedded tool urls, this affects all versions from when it was introduced. This causes videos that are added in lessons via /portal/tool to not work..

      This property is mostly used by video services like WarpWire and Kaltura for easy embedding. If it doesn't work then video won't play properly.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

              is related to

              Bug - A problem which impairs or prevents functionality of the product. SAK-39290 Centralize JS/CSS HTML head creation

              • Major - Major loss of function or need for functionality in production in the near future.
              • Awaiting Review
              relates to

              Bug - A problem which impairs or prevents functionality of the product. SAK-38887 portal.include.extrahead should be incorporated in HtmlPageFilter

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED

                Activity

                  People

                  • Assignee:
                    ern Earle R Nietzel
                    Reporter:
                    jonespm Matthew Jones
                  • Votes:
                    2 Vote for this issue
                    Watchers:
                    6 Start watching this issue

                    Dates

                    • Created:
                      Updated:

                      Git Integration