Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-31997

Iframe-like elements not responsive when inserted via CKeditor

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 11.2
    • Fix Version/s: None
    • Component/s: morpheus
    • Labels:
      None
    • Test Plan:
      Hide

      For the following elements

      <video>, <object>, <embed>, <iframe>

      1/ Add to an HTML page with a fixed size - make the page really wide, they should stop expanding at the size specified by "height" and "width" elements. Make the page thin, the elements should squish right down in size.

      2/ Add to a page with no size given - make the page really wide, they should stop expanding at their natural size. Make the page thin, the elements should squish right down in size.

      3/ Repeat 1 but add to a variety of tools, eg, Lessons, Polls, announcements, Forums (Note: You cannot add an embed or iframe tag to these tools as AntiSamy strips it).

      4/ Repeat 2 but add to a variety of tools, eg, Lessons, Polls, announcements, Forums (Note: You cannot add an embed or iframe tag to these tools as AntiSamy strips it).

      5/ Create HTML pages in Resources with these 4 things and go to Lessons tool and select Add Content Link and Select File from Resources and select the HTML pages and make sure they work as 1/ and 2/ specify.

      6/ On a mobile, do regression testing on the pop up help - make sure it behaves in the same way as before this patch was applied. Do the same with the Overview tool / page when it has synoptic tools. Test also that any other tools that still use iFrames still work correctly, eg, Overview tool w/ synoptic displays.

      Show
      For the following elements <video>, <object>, <embed>, <iframe> 1/ Add to an HTML page with a fixed size - make the page really wide, they should stop expanding at the size specified by "height" and "width" elements. Make the page thin, the elements should squish right down in size. 2/ Add to a page with no size given - make the page really wide, they should stop expanding at their natural size. Make the page thin, the elements should squish right down in size. 3/ Repeat 1 but add to a variety of tools, eg, Lessons, Polls, announcements, Forums (Note: You cannot add an embed or iframe tag to these tools as AntiSamy strips it). 4/ Repeat 2 but add to a variety of tools, eg, Lessons, Polls, announcements, Forums (Note: You cannot add an embed or iframe tag to these tools as AntiSamy strips it). 5/ Create HTML pages in Resources with these 4 things and go to Lessons tool and select Add Content Link and Select File from Resources and select the HTML pages and make sure they work as 1/ and 2/ specify. 6/ On a mobile, do regression testing on the pop up help - make sure it behaves in the same way as before this patch was applied. Do the same with the Overview tool / page when it has synoptic tools. Test also that any other tools that still use iFrames still work correctly, eg, Overview tool w/ synoptic displays.

      Description

      There is a problem with elements inserted via CK Editor that behave like an iframe: <video>, <object>, <embed>, <iframe> (but not iframes used on the Overview / Home page or in the pop-up help).

      Add some intelligent code so that such elements shrink on a mobile but "work as expected" on desktops.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  nickwilson Nick Wilson
                  Reporter:
                  nickwilson Nick Wilson
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code