Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-32031

If no groups in a site, error is thrown from velocity template

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.3
    • Fix Version/s: 11.3, 12.0
    • Component/s: Site Info
    • Labels:
    • 11 status:
      Resolved
    • 10 status:
      Please Merge
    • Test Plan:
      Hide

      Here's how I think I was reproducing this (maybe other ways)

      • Go to a "My Workspace"
      • Click on the checkbox next to a site and click Edit. Error appears in the logs. (Expected no error)

      This might also appear on a regular site with no groups in it.

      Show
      Here's how I think I was reproducing this (maybe other ways) Go to a "My Workspace" Click on the checkbox next to a site and click Edit. Error appears in the logs. (Expected no error) This might also appear on a regular site with no groups in it.

      Description

      In my local host I'm seeing this error.

      17-Dec-2016 18:50:02.713 ERROR [http-nio-8080-exec-9] velocity.sakai.site.manage.tool.log Left side ($!joinableGroups.size()) of '>' operation has null value at /vm/sitesetup/chef_site-siteInfo-list.vm[line 410, column 70]
      17-Dec-2016 18:50:02.718 ERROR [http-nio-8080-exec-9] velocity.sakai.site.manage.tool.log Left side ($!joinableGroups.size()) of '>' operation has null value at /vm/sitesetup/chef_site-siteInfo-list.vm[line 487, column 55]
      

      I don't see any mention of this before and it doesn't seem to be causing any functional issues, it's just coming up a lot. It looks like the logic for this was introduced back in SAK-22858. It seems like this is an easy fix, just don't include the context.put inside of the size check.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                rsanchez Ramon Sanchez
                Reporter:
                jonespm Matthew Jones
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code