Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-32137

Instructors can change course site title during initial creation even if choosing a roster

    Details

    • 11 status:
      Merge
    • Test Plan:
      Hide
      • Create a new course site using a roster. Confirm that the site title matches the roster title and cannot be edited by the user.
      • Create a new course site using the "Continue with no roster" option. Confirm that the site title can be edited by the user.
      • Create a new course site, selecting a roster at first and then going back and using the "Continue with no roster" option. Confirm that the site title no longer matches the roster you previously selected, and that you can edit the site title. Also check that when using the official description, it is also cleared after going back to continue with no roster.
      • Try out various scenarios of moving through the wizard screens and choosing different options related to roster/no roster selection, site title, and site description, in different orders. Confirm there are no cases where user-entered data is lost without reason.
      Show
      Create a new course site using a roster. Confirm that the site title matches the roster title and cannot be edited by the user. Create a new course site using the "Continue with no roster" option. Confirm that the site title can be edited by the user. Create a new course site, selecting a roster at first and then going back and using the "Continue with no roster" option. Confirm that the site title no longer matches the roster you previously selected, and that you can edit the site title. Also check that when using the official description, it is also cleared after going back to continue with no roster. Try out various scenarios of moving through the wizard screens and choosing different options related to roster/no roster selection, site title, and site description, in different orders. Confirm there are no cases where user-entered data is lost without reason.

      Description

      By default, the title of a course site is not editable.

      In SAK-29823 we enforced the titleNotEditable property in all scenarios, including initial site creation, so that instructors could not change the title of a course site. This assumed that a roster would always be chosen for the course site and the title would be taken from the roster. This lead to problems when the "Continue with no roster" feature was enabled (it is off by default), so in SAK-31261 changes were made to address that problem which essentially reverted SAK-29823, allowing instructors to change course site titles during site creation.

      This patch attempts to address both uses cases above. If a course site is using a roster, the title will not be editable. If an instructor chooses to "Continue with no roster", a site title must be provided, so we allow it to be edited. This is accomplished by checking to see if a roster is attached or not.

      Due to the setup process being a wizard that maintains state between pages, it is possible to first select a roster, then go back and decide to continue with no roster. Previously the old roster would remain in the state and would be considered attached for the checks above, so this patch clears any roster selections from the state when "Continue with no roster" is chosen. It also attempts to detect if the site title and/or description were assigned by the roster selection and removes them unless the user has edited them already.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  plukasew Paul Lukasewych
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code