Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-32464

More details for null parameters in edu-services

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.4, 12.0
    • Fix Version/s: 11.4, 12.0
    • Component/s: edu-services
    • Labels:
      None
    • 11 status:
      Resolved

      Description

      Getting some more details from SAK-32357 but still some error messages without enough information are coming back in the logs. Add some more details to the exception so we can figure out what's passed and why it's failing.

      18-Apr-2017 10:42:19.991 INFO [http-apr-8543-exec-92] org.sakaiproject.basiclti.util.SakaiBLTIUtil.handleGradebook Added assignment: Testing VT Fix 2
      18-Apr-2017 10:42:19.992 WARN [http-apr-8543-exec-92] org.sakaiproject.basiclti.util.SakaiBLTIUtil.handleGradebook handleGradebook Grade failure in site:2a9b62e7-2df9-4964-a160-4fbaa44a8df4
      java.lang.IllegalArgumentException: null parameter passed to getAssignmentScoreString
              at org.sakaiproject.component.gradebook.GradebookServiceHibernateImpl.getAssignmentScoreString(GradebookServiceHibernateImpl.java:2382)
              at sun.reflect.GeneratedMethodAccessor5351.invoke(Unknown Source)
              at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
              at java.lang.reflect.Method.invoke(Method.java:498)
              at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:302)
              at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
              at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
              at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)
              at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:281)
              at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)
              at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
              at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
              at com.sun.proxy.$Proxy113.getAssignmentScoreString(Unknown Source)
              at org.sakaiproject.basiclti.util.SakaiBLTIUtil.handleGradebook(SakaiBLTIUtil.java:1712)
      

      This one could be any of 3 values from
      String actualGrade = g.getAssignmentScoreString(siteId, assignmentObject.getId(), user_id);
      So need more details

      18-Apr-2017 10:40:40.371 WARN [http-apr-8543-exec-72] org.sakaiproject.basiclti.util.SakaiBLTIUtil.handleGradebook handleGradebook Grade failure in site:2a9b62e7-2df9-4964-a160-4fbaa44a8df4
      java.lang.NullPointerException
              at org.sakaiproject.component.gradebook.BaseHibernateManager.getAssignmentWithoutStats(BaseHibernateManager.java:231)
              at org.sakaiproject.component.gradebook.GradebookServiceHibernateImpl$21.doInHibernate(GradebookServiceHibernateImpl.java:2454)
              at org.springframework.orm.hibernate3.HibernateTemplate.doExecute(HibernateTemplate.java:410)
              at org.springframework.orm.hibernate3.HibernateTemplate.execute(HibernateTemplate.java:341)
              at org.sakaiproject.component.gradebook.GradebookServiceHibernateImpl.setAssignmentScoreString(GradebookServiceHibernateImpl.java:2452)
              at sun.reflect.GeneratedMethodAccessor11317.invoke(Unknown Source)
              at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
              at java.lang.reflect.Method.invoke(Method.java:498)
              at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:302)
              at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
              at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
              at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)
              at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:281)
              at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)
              at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
              at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
              at com.sun.proxy.$Proxy113.setAssignmentScoreString(Unknown Source)
              at org.sakaiproject.basiclti.util.SakaiBLTIUtil.handleGradebook(SakaiBLTIUtil.java:1732)
      

      This is called from
      g.setAssignmentScoreString(siteId, assignmentObject.getId(), user_id, getRoundedGrade(theGrade,assignmentObject.getPoints()), "External Outcome");

      And looks like it's because setLong(0 ,assignmentId) fails.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code