Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-32562

Gradebook decimal separator inconsistency

    Details

    • 12 status:
      Resolved
    • 11 status:
      Please Merge
    • Test Plan:
      Hide

      1. Create a course site
      2. Set the site language to one that uses commas (,) as decimal separator, e.g. Swedish
      3. Add and navigate to Gradebook tool
      4. Make sure grades are awarded as points (in tool settings tab)
      5. Add gradebook item with a comma as decimal separator, e.g. "1,0"
      6. Use the item dropdown and click "Set score for empty cells"
      7. Set a value, e.g. "0,5"

      Expected result: every empty cell is populated with the set value

      Current result (bug): error message "Item score must be a positive number/decimal with a maximum of 10 integers and 2 decimal places."

      Show
      1. Create a course site 2. Set the site language to one that uses commas (,) as decimal separator, e.g. Swedish 3. Add and navigate to Gradebook tool 4. Make sure grades are awarded as points (in tool settings tab) 5. Add gradebook item with a comma as decimal separator, e.g. "1,0" 6. Use the item dropdown and click "Set score for empty cells" 7. Set a value, e.g. "0,5" Expected result: every empty cell is populated with the set value Current result (bug): error message "Item score must be a positive number/decimal with a maximum of 10 integers and 2 decimal places."

      Description

      When the site language is set to one that uses comma (,) as decimal place separator it is not possible to "Set score for empty cells" in Gradebook. Please see test plan for steps to reproduce.

      Neither comma nor point (dot) decimal separators are accepted in the modal window, as both return the error message "Item score must be a positive number/decimal with a maximum of 10 integers and 2 decimal places." The display value in the modal text field is not using the proper locale format either.

      There is a proposed fix in the works, which I will create I pull request for.

      Possible to reproduce on nightly 11.3 and 12 master/trunk. Earlier releases not tested.

        Gliffy Diagrams

          Attachments

          1. dropdown-menu.png
            dropdown-menu.png
            35 kB
          2. using-comma.png
            using-comma.png
            36 kB
          3. using-point.png
            using-point.png
            31 kB

            Issue Links

              Activity

                People

                • Assignee:
                  farreri Miguel Pellicer
                  Reporter:
                  LHSnow Lars-Henrik Snow
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code