Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-32599

Problem with new copyright dialog and weblinks

    Details

    • 11 status:
      Resolved
    • Test Plan:
      Hide
      Turn on the property
      content.url.rightsdialog=true

      Add a Web Content URL and add optional details to display the copyright notice.
      - Click it once, click Okay, notice it works
      - Try to click it again, notice nothing happens

      It should go to the resource again in the second click.
      Show
      Turn on the property content.url.rightsdialog=true Add a Web Content URL and add optional details to display the copyright notice. - Click it once, click Okay, notice it works - Try to click it again, notice nothing happens It should go to the resource again in the second click.

      Description

      The feature < > added a new popup dialog box to access. This seems to work fine now for content on the same domain, but if it's a URL what appears to happen is the Location redirect could be blocked as a CORS security request. There isn't much details about when this happens and it seems like it's checked at the network level so there's no way to pre-check or get around it at the browser.

      I have one idea for fixing it, that's to just try to do the form redirect if there's any error, but I guess there could be other errors and it looks like this method is triggering a popup blocked box (In Chrome)

      Another idea might be if the server had a special way to check if the web-linked domain would be blocked by CORS, then this could be queried prior to checking, but I believe it would need to happen server-server. I'm not sure how used this feature is so maybe the quick fix is fine.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code