Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-32701

many issues when managing subgroups via a CSV file

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 12.0
    • Fix Version/s: 12.1, 19.0
    • Component/s: Site Info
    • Labels:
      None
    • 12 status:
      Resolved
    • 11 status:
      Please Merge
    • Test Plan:
      Hide

      Create the following users via Users tool in admin workspace:

      • adamm
      • buckett
      • ouit0196
      • stuart

      Create a site and add

      • adamm
      • buckett
      • ouit0196

      to the site.

      Visit site. Site Info > manage Groups > Bulk Creation then use 4 attached CSV files

      • groups.csv - has 2 groups and 2 different users who are both site members
      • groups1.csv - has same 2 groups as above and 3 (or more) different users who are all site members
      • groups2.csv - has a user who doesnt exist in the system
      • groups3.csv - has a user who does exist but who isnt a site member

      Upload one CSV file followed by a second (groups.csv followed by groups1.csv) without doing a tool reset (ie, clicking on the tool name in the LHS menu), you should NOT see a message "The file you uploaded was not readable. Please check the file is of the correct format, and try again." - you should be able to upload one file after another. 

      If you load the two files (groups.csv followed by groups1.csv) the second file generates poor messages, see screenshot-1 

      #1 This message should NOT appear "The data you supplied contained invalid users, matched multiple users or users who are not part of the site (highlighted in red). You need to correct these issues and start again." All users in groups1.csv are site members so everything should work.

      #2.1 the NEW users are shown in black (it may possibly be grey); the existing users are in red, 
      #2.2 we should not reply on colour coding, what about blind people? - instead of colour coding, prefix the existing user list with text "Existing user" 
      #2.3 the users should not be listed by their "Sakai internal ID", we should be showing the identifier that was given in the spreadsheet (eg, username) and they shouldnt be shown in red. 

      #3 There needs to be a "Save" button so you can continue.

      Check the following is in place

      A: The group name is prefixed by "Group: " in the <h3> 
      B: List the users to be added in a <ol> list with appropriate <h4> heading
      C: list the existing users in an <ol> list with appropriate <h4> heading

      The file groups2.csv includes a user that doesnt exist in the system, import it 

      This time the message in blue "The data you supplied contained invalid users, matched multiple users or users who are not part of the site (highlighted in red). You need to correct these issues and start again." is along the right lines except we shouldnt be colour coding,

      Check

      A: The group name is prefixed by "Group: " in the <h3> 
      B: list the troublesome users in an <ol> list and prefix with an <h4> heading such as 'User is not a site participant:' - this would include non-existent users and users who arent site members (see groups3.csv) 

      groups3.csv includes a non site member who does exisit in the system 

      This is effective the same as above but contains a non site member, it should be handled just like the above. 

      On the 'verify' page check that there are Cancel & Back buttons, 'Cancel' takes you back to the main "Manage Subgroups" page, 'Back' does a JavaScript Back and takes you back to the select a file / type into the text area page. If data has been typed into the textbox then it should still be there. It doesn't matter if the attached file has vanished though.

      Show
      Create the following users via Users tool in admin workspace: adamm buckett ouit0196 stuart Create a site and add adamm buckett ouit0196 to the site. Visit site. Site Info > manage Groups > Bulk Creation then use 4 attached CSV files groups.csv - has 2 groups and 2 different users who are both site members groups1.csv - has same 2 groups as above and 3 (or more) different users who are all site members groups2.csv - has a user who doesnt exist in the system groups3.csv - has a user who does exist but who isnt a site member Upload one CSV file followed by a second (groups.csv followed by groups1.csv) without doing a tool reset (ie, clicking on the tool name in the LHS menu), you should NOT see a message "The file you uploaded was not readable. Please check the file is of the correct format, and try again." - you should be able to upload one file after another.  If you load the two files (groups.csv followed by groups1.csv) the second file generates poor messages, see screenshot-1  #1 This message should NOT appear "The data you supplied contained invalid users, matched multiple users or users who are not part of the site (highlighted in red). You need to correct these issues and start again." All users in groups1.csv are site members so everything should work. #2.1 the NEW users are shown in black (it may possibly be grey); the existing users are in red,  #2.2 we should not reply on colour coding, what about blind people? - instead of colour coding, prefix the existing user list with text "Existing user"  #2.3 the users should not be listed by their "Sakai internal ID", we should be showing the identifier that was given in the spreadsheet (eg, username) and they shouldnt be shown in red.  #3 There needs to be a "Save" button so you can continue. Check the following is in place A: The group name is prefixed by "Group: " in the <h3>  B: List the users to be added in a <ol> list with appropriate <h4> heading C: list the existing users in an <ol> list with appropriate <h4> heading The file groups2.csv includes a user that doesnt exist in the system, import it  This time the message in blue "The data you supplied contained invalid users, matched multiple users or users who are not part of the site (highlighted in red). You need to correct these issues and start again." is along the right lines except we shouldnt be colour coding, Check A: The group name is prefixed by "Group: " in the <h3>  B: list the troublesome users in an <ol> list and prefix with an <h4> heading such as 'User is not a site participant:' - this would include non-existent users and users who arent site members (see groups3.csv)  groups3.csv includes a non site member who does exisit in the system  This is effective the same as above but contains a non site member, it should be handled just like the above.  On the 'verify' page check that there are Cancel & Back buttons, 'Cancel' takes you back to the main "Manage Subgroups" page, 'Back' does a JavaScript Back and takes you back to the select a file / type into the text area page. If data has been typed into the textbox then it should still be there. It doesn't matter if the attached file has vanished though.

      Description

      you need 4 CSV files

      • groups.csv - has 2 groups and 2 different users who are both site members
      • groups1.csv - has same 2 groups as above and 3 (or more) different users who are all site members
      • groups2.csv - has a user who doesnt exist in the system
      • groups3.csv - has a user who does exist but who isnt a site member

      If you upload one CSV file followed by a second (groups.csv followed by groups1.csv) without doing a tool reset (ie, clicking on the tool name in the LHS menu), you see a message "The file you uploaded was not readable. Please check the file is of the correct format, and try again." This is wrong - you should be able to upload one file after another. 

      If you load the two files and do a tool reset in the middle, the second file generates poor messages, see screenshot-1 

      #1 The instruction message says "The data you supplied contained invalid users, matched multiple users or users who are not part of the site (highlighted in red). You need to correct these issues and start again." - this is not true, all users in groups1.csv are site members. Assuming the merging actually works, it should not be there (but we do want the message when one of the conditions it mentions is encountered). 

      The message in grey about merging users should be left in tact. 

      #2 The message underneath the group name IS wrong 

      #2.1 the NEW users are shown in black (it may possibly be grey); the existing users are in red, 
      #2.2 we should not reply on colour coding, what about blind people? - prefix the existing users with text "Existing user" 
      #2.3 the users given in red are listed by their ID, we should be showing the ID that was givenm in the spreadsheet and they shouldnt be shown in red. 

      #3 There is no "Save" button so you cant continue - this may be because of the blue error message, it looks like Sakai believes there's an error when there is not. 

      The whole layout of the page could be better. 

      A: Prefix the group name by "Group: " in the <h3> 
      B: List the users to be added in a <ol> list 
      C: list the existing users in an <ol> list 

      The file groups2.csv includes a user that doesnt exist in the system, import it 

      This time the message in blue "The data you supplied contained invalid users, matched multiple users or users who are not part of the site (highlighted in red). You need to correct these issues and start again." is along the right lines except we shouldnt be colour coding, I suggest 

      A: Prefix the group name by "Group: " in the <h3> 
      B: list the troublesome users in an <ol> list and prefix with 'User is not a site participant:' - this would include non-existant users and users who arent site members (see groups3.csv) 

      groups3.csv includes a non site member who does exisit in the system 

      This is effective the same as above but contains a non site member, it should be handled just like the above. 

      Tentative suggestion: allow the contents of the CSV file to be pasted into a (big) text box as an alternative. 

      Added after the Jira was created:
      On the 'verify' page have Cancel & Back buttons
      'Cancel' takes you back to the main "Manage Subgroups" page
      'Back' does a JavaScript Back and takes you back to the select a file / type into the text area page. If data has been typed into the textbox then it should still be there. it doesn't matter if the attached file has vanished though.

        Gliffy Diagrams

          Attachments

          1. groups.csv
            0.1 kB
          2. groups1.csv
            0.1 kB
          3. groups2.csv
            0.1 kB
          4. groups3.csv
            0.1 kB
          5. PostFix1.JPG
            PostFix1.JPG
            28 kB
          6. PostFix2.JPG
            PostFix2.JPG
            39 kB
          7. PostFix3.JPG
            PostFix3.JPG
            30 kB
          8. PostFix4.JPG
            PostFix4.JPG
            27 kB
          9. screenshot-1.png
            screenshot-1.png
            42 kB

            Issue Links

              Activity

                People

                • Assignee:
                  rebeccam Rebecca Miller
                  Reporter:
                  adamm Adam Marshall
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code